Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight important packages #217

Closed
maleadt opened this issue Mar 13, 2023 · 3 comments · Fixed by #233
Closed

Highlight important packages #217

maleadt opened this issue Mar 13, 2023 · 3 comments · Fixed by #233

Comments

@maleadt
Copy link
Member

maleadt commented Mar 13, 2023

Some packages are important to keep working (SnoopCompile, Cthulhu, GPUCompiler, Revise, etc), so we should consider highlighting them in the PkgEval reports. For example, always list them at the top, just like we do with crashes.
@Keno
Copy link
Member

Keno commented Oct 25, 2023

Revise appears to be blacklisted currently, so the breakage wasn't caught in the PkgEval run in JuliaLang/julia#49866. Can we fix that?

@maleadt
Copy link
Member Author

maleadt commented Oct 25, 2023

Yeah, I can add a whitelist or so to keep packages from getting excluded. Do note that Revise was blacklisted automatically though, i.e., it must have been failing continuously before, so it's unlikely that we'd have caught it further regressing.

@Keno
Copy link
Member

Keno commented Oct 25, 2023

Fair enough, but let's whitelist it and then figure out why it's broken

@maleadt maleadt mentioned this issue Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep track of important packages that should not get blacklisted JuliaCI/PkgEval.jl
2 participants
@maleadt @Keno