Supergalactic Coordinates #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhro
reviewed
May 12, 2024
abhro
reviewed
May 12, 2024
Co-authored-by: abhro <5664668+abhro@users.noreply.github.com>
Co-authored-by: abhro <5664668+abhro@users.noreply.github.com>
|
Thanks @abhro! Sorry for the late reply, I only just saw it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I need to convert between Supergalactic and Galactic coordinates for an upcoming paper, so I implemented it here.
The implementation is based on astropy.
Tests for converting between Supergalactic and Galactic pass, but the rest don't.
Since I have zero experience with working in the other coordinate systems I'd be greatful for a second pair of eyes on where my mistake lies.
I hope that despite this issue it's still a useful contribution to the package.
Cheers,
Ludwig