Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cartesian and Canonical transformations are not always inverse operations #3

Closed
cadojo opened this issue Sep 18, 2020 · 1 comment
Closed

Cartesian and Canonical transformations are not always inverse operations #3

cadojo opened this issue Sep 18, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@cadojo
Copy link
Collaborator

cadojo commented Sep 18, 2020

There is likely an issue with the orbit orientation parameter calculations in CanonicalOrbit(::CartesianOrbit). Is 2 * pi - ... the correct calculation?
@cadojo cadojo mentioned this issue Sep 19, 2020
Merged
@cadojo
Copy link
Collaborator Author

cadojo commented Sep 19, 2020

Closed with #4

@cadojo cadojo closed this as completed Sep 19, 2020
@cadojo cadojo added the bug Something isn't working label Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cadojo