Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: address unsafe pointer operations (segfaults on nightly) #196

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sefffal
Copy link
Member

@sefffal sefffal commented Apr 30, 2024

These changes begin to address the unsafe operations used in this package.
Currently these just deal with the most obvious issues.
Repeatedly running tests on nightly reveal that there are still segfaults. I believe we are leaking pointers to C somewhere. This will also have to be addressed.

Note that tests are failing due to an unrelated issue with complex arrays that also impacts nightly.

Edit: there are some unrelated changes in the first three commits I will excise from this PR.

@jishnub
Copy link
Contributor

jishnub commented Jun 6, 2024

I think it's fine to remove the reinterpreted complex tests (I was the one who had added these). These aren't relevant for the package as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants