From a810253487909b47189d4c905fc41a2ca7b50179 Mon Sep 17 00:00:00 2001 From: Miha Zgubic Date: Fri, 30 Apr 2021 11:20:09 +0100 Subject: [PATCH 1/4] remove custom to_vec --- src/BlockDiagonals.jl | 1 - src/finitedifferences.jl | 6 ------ test/finitedifferences.jl | 14 -------------- 3 files changed, 21 deletions(-) delete mode 100644 src/finitedifferences.jl delete mode 100644 test/finitedifferences.jl diff --git a/src/BlockDiagonals.jl b/src/BlockDiagonals.jl index 5a2a4d1..dad4837 100644 --- a/src/BlockDiagonals.jl +++ b/src/BlockDiagonals.jl @@ -13,6 +13,5 @@ include("blockdiagonal.jl") include("base_maths.jl") include("chainrules.jl") include("linalg.jl") -include("finitedifferences.jl") end # end module diff --git a/src/finitedifferences.jl b/src/finitedifferences.jl deleted file mode 100644 index 270b796..0000000 --- a/src/finitedifferences.jl +++ /dev/null @@ -1,6 +0,0 @@ -function FiniteDifferences.to_vec(X::BlockDiagonal) - x, blocks_from_vec = to_vec(blocks(X)) - BlockDiagonal_from_vec(x_vec) = BlockDiagonal(blocks_from_vec(x_vec)) - return x, BlockDiagonal_from_vec -end - diff --git a/test/finitedifferences.jl b/test/finitedifferences.jl deleted file mode 100644 index 784b213..0000000 --- a/test/finitedifferences.jl +++ /dev/null @@ -1,14 +0,0 @@ -function test_to_vec(x::T; check_inferred = true) where {T} - check_inferred && @inferred to_vec(x) - x_vec, back = to_vec(x) - @test x_vec isa Vector - @test all(s -> s isa Real, x_vec) - check_inferred && @inferred back(x_vec) - @test x == back(x_vec) - return nothing -end - -@testset "finitedifferences.jl" begin - b = BlockDiagonal([rand(2, 2), rand(3, 4)]) - test_to_vec(b) -end From bc950c2390d13ab280ac3a15e312a8e23ae16507 Mon Sep 17 00:00:00 2001 From: Miha Zgubic Date: Fri, 30 Apr 2021 11:20:27 +0100 Subject: [PATCH 2/4] add compat --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index c12003a..ec74a71 100644 --- a/Project.toml +++ b/Project.toml @@ -13,7 +13,7 @@ LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" ChainRulesCore = "0.9" ChainRulesTestUtils = "0.6.3" FillArrays = "0.6, 0.7, 0.8, 0.9, 0.10, 0.11" -FiniteDifferences = "0.12" +FiniteDifferences = "0.12.3" julia = "1" [extras] From 51a83fc8259e13d8e8fdf7ca2ede259f173ed756 Mon Sep 17 00:00:00 2001 From: Miha Zgubic Date: Fri, 30 Apr 2021 11:27:24 +0100 Subject: [PATCH 3/4] remove from testing --- test/runtests.jl | 1 - 1 file changed, 1 deletion(-) diff --git a/test/runtests.jl b/test/runtests.jl index fcc8e01..4938e0b 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -12,6 +12,5 @@ using LinearAlgebra include("blockdiagonal.jl") include("base_maths.jl") include("chainrules.jl") - include("finitedifferences.jl") include("linalg.jl") end # tests From aa8b2cad2e3b3a77fbd3a2aab3f45a21152d7646 Mon Sep 17 00:00:00 2001 From: Miha Zgubic Date: Fri, 30 Apr 2021 11:28:09 +0100 Subject: [PATCH 4/4] bump patch --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index ec74a71..6812795 100644 --- a/Project.toml +++ b/Project.toml @@ -1,7 +1,7 @@ name = "BlockDiagonals" uuid = "0a1fb500-61f7-11e9-3c65-f5ef3456f9f0" authors = ["Invenia Technical Computing Corporation"] -version = "0.1.17" +version = "0.1.18" [deps] ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"