Skip to content

Commit 34fb0d5

Browse files
committed
Fix _perm_tuple and remove old note
1 parent 6ca4539 commit 34fb0d5

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/dimensions.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ end
206206
@generated function _perm_tuple(::Type{T}, ::Val{P}) where {T,P}
207207
out = Expr(:curly, :Tuple)
208208
for p in P
209-
push!(out.args, :(T.parameters[$p]))
209+
push!(out.args, T.parameters[p])
210210
end
211211
Expr(:block, Expr(:meta, :inline), out)
212212
end

src/stridelayout.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ function dense_dims(::Type{<:PermutedDimsArray{T,N,I1,I2,A}}) where {T,N,I1,I2,A
228228
end
229229
end
230230
function dense_dims(::Type{S}) where {N,NP,T,A<:AbstractArray{T,NP},I,S<:SubArray{T,N,A,I}}
231-
return _dense_dims(S, dense_dims(A), Val(stride_rank(A))) # TODO fix this
231+
return _dense_dims(S, dense_dims(A), Val(stride_rank(A)))
232232
end
233233

234234
_dense_dims(::Any, ::Any) = nothing

0 commit comments

Comments
 (0)