Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible test failure (again!) in upcoming Julia version 1.5 #286

Closed
rfourquet opened this issue May 3, 2020 · 2 comments
Closed

possible test failure (again!) in upcoming Julia version 1.5 #286

rfourquet opened this issue May 3, 2020 · 2 comments

Comments

@rfourquet
Copy link

A PkgEval run for a Julia pull request which changes the generated numbers for rand(a:b) indicates that the tests of this package might fail in Julia 1.5 (and on Julia current master branch).

Also, you might be interested in using the new StableRNGs.jl registered package, which provides guaranteed stable streams of random numbers across Julia releases.

Apologies if this is a false positive. Cf. https://github.com/JuliaCI/NanosoldierReports/blob/ab6676206b210325500b4f4619fa711f2d7429d2/pkgeval/by_hash/52c2272_vs_47c55db/logs/MLJBase/1.5.0-DEV-87d2a04de3.log

@tlienart
Copy link
Collaborator

tlienart commented May 8, 2020

@ablaom In the context of #292 I ran the test suite on 1.5 without issue but I would still think that using StableRNG in the testss would be great to avoid future potential headaches?

I'm going to shift to it in MLJLinearModels

@ablaom
Copy link
Member

ablaom commented May 10, 2020

Sounds like a good idea. I did not know there was a multi-julia version fix for this, so thanks for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants