Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add compileOptions JavaVersion.VERSION_1_8 #133

Merged
merged 1 commit into from
Oct 19, 2020
Merged

fix: Add compileOptions JavaVersion.VERSION_1_8 #133

merged 1 commit into from
Oct 19, 2020

Conversation

PetterIve
Copy link
Contributor

closes #132

@Rapsssito Rapsssito changed the title chore: add compileOptions fix: Add compileOptions JavaVersion.VERSION_1_8 Oct 9, 2020
eliaslecomte
eliaslecomte approved these changes Oct 12, 2020
View reviewed changes
Copy link
Collaborator

@eliaslecomte eliaslecomte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @PetterIve!
I think adding the compileOptions is a good idea. This seems to be required due to the updated WifiUtils dependency.

I think it depends on the java version you are running if you get this error or not. So I am curious: What java version are you using?

@eliaslecomte eliaslecomte self-assigned this Oct 12, 2020
@PetterIve
Copy link
Contributor Author

Good stuff!

openjdk version "1.8.0_242"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_242-b08)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.242-b08, mixed mode)

@PetterIve
Copy link
Contributor Author

@eliaslecomte Any idea when this will be merged/released? :)

@Rapsssito Rapsssito merged commit f28a8dc into JuanSeBestia:master Oct 19, 2020
JuanSeBestia pushed a commit that referenced this pull request Oct 19, 2020
@semantic-release-bot
chore(release): 4.3.3 [skip ci]
79ca227 
## [4.3.3](v4.3.2...v4.3.3) (2020-10-19)

### Bug Fixes

* Add compileOptions JavaVersion.VERSION_1_8 ([#133](#133)) ([f28a8dc](f28a8dc))
@JuanSeBestia
Copy link
Owner

🎉 This PR is included in version 4.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliaslecomte eliaslecomte eliaslecomte approved these changes

Assignees

@eliaslecomte eliaslecomte

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build.gradle missing compileOptions causes build error when compiling debug app
4 participants
@PetterIve @JuanSeBestia @eliaslecomte @Rapsssito