Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use directly phantomjs module instead of phantom #5

Closed
piranna opened this issue Sep 13, 2015 · 8 comments
Closed

Use directly phantomjs module instead of phantom #5

piranna opened this issue Sep 13, 2015 · 8 comments

Comments

@piranna
Copy link
Contributor

piranna commented Sep 13, 2015

phantomjs module automatically installs PhantomJS so it's not needed to be installed externally, so it would help to make books more autocontained and generated by non-tech people just by doing npm install.
@piranna
Copy link
Contributor Author

piranna commented Sep 13, 2015

Also, phantomjs modules is more updated and maintained (one month versus 8 months of phantom) and used by 10x people of phantom...

@piranna
Copy link
Contributor Author

piranna commented Oct 12, 2015

This has been fixed on pull-request #11. phantom module is still required because phantomjs only download the binary, but I've managed instead to ask him the location of the binary instead of depend only on a globally installed one.

@JozoVilcek
Copy link
Owner

I have merged your pull request. Thanks for this. I like the solution

@piranna
Copy link
Contributor Author

piranna commented Oct 14, 2015

You are welcome :-) Could this be possible to be published on npm, too?

@JozoVilcek
Copy link
Owner

Sure, I will publish as soon as I resolve #7

@piranna
Copy link
Contributor Author

piranna commented Oct 15, 2015

Ok, agree 👍

@JozoVilcek
Copy link
Owner

Released

@piranna
Copy link
Contributor Author

piranna commented Oct 15, 2015

Cool! :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@piranna @JozoVilcek