-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QueryNode: Support Event types not in latest runtime #4877
Comments
is this a query node issue, hydra issue? I'm adding nara label, correct me if wrong. |
This is specifically a hydra issue,during the query-node build process when generating processor specific code/types. Line 18 in a03082e
The typegen yarn script: For example, when the events are removed and I rebuild the node,update chain metadata files and run the QN build this is what the error looks like:
|
.. the typegen:
metadata:
source: ./chain-metadata/
events:
- palletA.EventName1
- palletB.EventName2 The folder contains multiple versions for each version of the runtime we support with the filenames as The problem as @zeeshanakram3 described is that hydra-typegen seems to be only looking at the latest chain-metadata. Possible solutions: typegen:
metadata:
source: ./chain-metadata/
events:
- palletA.EventName1,2001 # look in chain metadata for spec version 2001
- palletB.EventName2 # look in latest chain metadata C. ... ? |
When a new runtime removes an event variant, we can no longer reference it in the query-node/hydra manifest.yml as the metadata for the event runtime type is not found in the latest runtime. But we need to keep the mapping to handle the event when it was emitted in previous runtimes. (This is because we currently have a single set of mappings that need to work all the way from genesis)
Keeping around unused runtime types in the runtime is not ideal.
┆Issue is synchronized with this Asana task by Unito
The text was updated successfully, but these errors were encountered: