Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in src/scripts/docker-image.js for sha256 #201

Closed
PhracturedBlue opened this issue Jul 13, 2021 · 1 comment
Closed

Typo in src/scripts/docker-image.js for sha256 #201

PhracturedBlue opened this issue Jul 13, 2021 · 1 comment

Comments

@PhracturedBlue
Copy link

I was browsing the code, and I noticed this which is likely a typo:
File: src/scripts/docker-image.js

    this.on('get-sha256', function () {
      if (this.size !== undefined) {
        return this.trigger('sha256', this.sha256);
      }
      return this.fillInfo();
    });

I assume that size here should be sha256. It is unlikely to cause an issue since I don't think sha256 can be det without a size, but I thought I'd mention it.

@PhracturedBlue PhracturedBlue changed the title Typo in Typo in src/scripts/docker-image.js for sha256 Jul 13, 2021
@Joxit Joxit closed this as completed in db6b74a Jul 13, 2021
@Joxit
Copy link
Owner

Joxit commented Jul 13, 2021

Hi, thank you for using my project and taking time to review my code.

This should be fixed in 2.0.8 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants