Skip to content

Commit

Permalink
fix: support nodejs LTS versions
Browse files Browse the repository at this point in the history
Configure typescript to compile to es2018 instead of esnext.
fixes #51
  • Loading branch information
JonasKruckenberg committed Mar 30, 2021
1 parent 24a3a0f commit 4abccc5
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 3 deletions.
23 changes: 22 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,30 @@ on:
branches: ["main", "next"]

jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [10.x, 12.x, 14.x, 15.x]

steps:
- uses: actions/checkout@v2
with:
fetch-depth: "0"
lfs: true
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}
- name: Install deps
run: yarn
- name: Run unit tests
run: yarn test

release:
runs-on: ubuntu-latest
needs: test

steps:
- uses: actions/checkout@v2
with:
Expand All @@ -16,7 +38,6 @@ jobs:
with:
node-version: "14"
- run: yarn
- run: yarn test
- run: yarn build
- name: create npmrc file
run: echo //registry.npmjs.org/:_authToken=${NPM_TOKEN} > .npmrc
Expand Down
3 changes: 2 additions & 1 deletion packages/core/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
{
"compilerOptions": {
"target": "esnext",
"target": "es2018",
"module": "esnext",
"moduleResolution": "node",
"esModuleInterop": true,
"sourceMap": true,
"declaration": true,
"declarationDir": "dist",
"strict": true,
"lib": ["esnext","DOM","DOM.Iterable"],
"strictNullChecks": true
},
"include": [
Expand Down
2 changes: 1 addition & 1 deletion packages/vite/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"compilerOptions": {
"target": "esnext",
"target": "es2018",
"module": "esnext",
"moduleResolution": "node",
"esModuleInterop": true,
Expand Down

0 comments on commit 4abccc5

Please sign in to comment.