Misaligned tranformation for logical operators and and or

[dhruvmanila]

For the following config:

column_width = 80
line_endings = "Unix"
indent_type = "Spaces"
indent_width = 2
quote_style = "AutoPreferDouble"

The output for the following line:

local long_variable_name = some_condition("testing") and condition_was_true(true) or condition_was_false(false)

is:

local long_variable_name = some_condition("testing")
    and condition_was_true(true)
  or condition_was_false(false)

The and and or is not lined up. Is this the expected way or is it a bug?

[JohnnyMorganz]

This is actually expected. The and operator takes a higher precedence than the or operator, which is why it is indented one further to display this. [Similar example using prettier]

Lua has no real ternary operator here, so they don't have the same precedence. This actually leads to another thing I wanted to implement that prettier does, but haven't yet: adding parentheses to disambiguate associative. The expression is actually evaluated as (foo and bar) or baz, and the parentheses could help to show this. For example if you wrote foo and false or true to replicate a ternary, and foo was truths, this would actually evaluated to true no matter what happens!
I haven't decided to add these parentheses yet due to how common the "ternary pattern" is, so it may be quite invasive

[dhruvmanila]

Ah, right understood. Thanks for the explanation.