From ab1ca99206ad8f8ac2e16a4317ed9332c001790f Mon Sep 17 00:00:00 2001
From: Joel Marcey <joelm@fb.com>
Date: Thu, 14 Jun 2018 10:06:42 -0700
Subject: [PATCH] [RFC] Move custom translation strings to its own file

Fixes #713
---
 lib/write-translations.js                    | 12 ++++++------
 website/data/custom-translation-strings.json |  9 +++++++++
 2 files changed, 15 insertions(+), 6 deletions(-)
 create mode 100644 website/data/custom-translation-strings.json

diff --git a/lib/write-translations.js b/lib/write-translations.js
index 4bbfc73b722a..1c44f76020a9 100755
--- a/lib/write-translations.js
+++ b/lib/write-translations.js
@@ -20,13 +20,13 @@ const babylon = require('babylon');
 const traverse = require('babel-traverse').default;
 const sidebars = require(CWD + '/sidebars.json');
 
-let currentTranslations = {
+let overrideTranslations = {
   'localized-strings': {},
   'pages-strings': {},
 };
-if (fs.existsSync(CWD + '/i18n/en.json')) {
-  currentTranslations = JSON.parse(
-    fs.readFileSync(CWD + '/i18n/en.json', 'utf8')
+if (fs.existsSync(CWD + '/data/custom-translation-strings.json')) {
+  overrideTranslations = JSON.parse(
+    fs.readFileSync(CWD + '/data/custom-translation-strings.json', 'utf8')
   );
 }
 
@@ -158,11 +158,11 @@ function execute() {
     'Translate';
   translations['pages-strings'] = Object.assign(
     translations['pages-strings'],
-    currentTranslations['pages-strings']
+    overrideTranslations['pages-strings']
   );
   translations['localized-strings'] = Object.assign(
     translations['localized-strings'],
-    currentTranslations['localized-strings']
+    overrideTranslations['localized-strings']
   );
   writeFileAndCreateFolder(
     CWD + '/i18n/en.json',
diff --git a/website/data/custom-translation-strings.json b/website/data/custom-translation-strings.json
new file mode 100644
index 000000000000..4f663211b775
--- /dev/null
+++ b/website/data/custom-translation-strings.json
@@ -0,0 +1,9 @@
+{
+  "_comment": "This file is used to provide custom strings for translations, including overriding defaults",
+  "localized-strings": {
+    "translation": "Translations and Localization"
+  },
+  "pages-strings" : {
+        "Help Translate|recruit community translators for your project": "Help Us Translate"
+  }
+}