Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run whipper without installation #222

Merged
merged 3 commits into from
Jan 31, 2018
Merged

Conversation

vmx
Copy link
Contributor

@vmx vmx commented Jan 29, 2018

This commit makes it possible to run whipper directly with
python -m whipper from wither within the source directory
or with PYTHONPATH set to the source directory.

I'm not sure if that's generally useful or people other than my like running programs like that.

vmx added 3 commits January 29, 2018 01:47
This commit makes it possible to run whipper directly with
`python -m whipper` from wither within the source directory
or with `PYTHONPATH` set to the source directory.
If `accurate_checksum` was successfully built in `src` it will
automatically be found if whipper is run via `python -m whipper`.
@MerlijnWajer
Copy link
Collaborator

MerlijnWajer commented Jan 29, 2018

An alternative for you could be to set "$PATH" to "$PATH:pwd". I am not sure if unconditionally adding extra paths to $PATH is a good idea.

@vmx
Copy link
Contributor Author

vmx commented Jan 29, 2018

@MerlijnWajer The path is only added when running via python -m whipper not when installed in other ways (at least that was my plan).

@MerlijnWajer
Copy link
Collaborator

Oops, you're right. I think this is OK. @Freso - got an opinion on this?

@MerlijnWajer
Copy link
Collaborator

@Freso seems to ACK this.

@MerlijnWajer MerlijnWajer merged commit 852f459 into whipper-team:master Jan 31, 2018
@MerlijnWajer
Copy link
Collaborator

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants