Clean up files in misc/ #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pep8.py was added in 2012. Since then, we now have flake8 and a number of other really good PEP 8 (and other style, best practice, etc.) code checkers/linters. It doesn't make sense to track this directly in the repository. If we want to do automated code style/sanity checking, we should add a dependency on an actually maintained program/script rather than keeping it locally in the repository.
Was added in 2009 and not updated since. There are several Python coverage tools out there, and the current ./COVERAGE doesn't seem to be generated using this script either.
Not actually used by anything in the current codebase and PyChecker doesn't seem to be the recommended Python code style checker or linting tool currently. If we need a configuration file for another tool later on, we can make one then based on current need and wants.
|
@JoeLametta said to toss |
A script that sets up an environment for running whipper without actually installing it. With the clean ups that have happened to whipper as well as later developments in the Python eco system, simply setting up a virtualenv and running whipper from within that seems like a more reasonable approach at this time. This also fixes #47 by removing the "morituri-uninstalled mode" completely. :)
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for reasoning. (Also somewhat related to #5 in that some of this is removing scripts from elsewhere that are likely better maintained in their own repositories/domains.)
Stragglers that I'm unsure about:
misc/header.py: Template file for new files with GPL copyright blurb andvimode lines.misc/offsets.py: Script to get some statistics about common offsets. Might still be relevant/useful and doesn't seem like code suited for elsewhere.misc/pycheckerrc: Configuration file forpychecker. Doesn't seem to be referenced anywhere in the code. I'm leaning towards removing this: if we want a configuration file for a Python linter, it should probably be in a place where CI would pick it (either automatically or because we direct it there).flake8orpylintseems to be the choices to go for here though, neither of which arepychecker. But maybe hold ontopycheckerrcuntil we do implement something like this so we can crossreference the settings? Or just drop this since whipper has already moved away where morituri was in 2009 (when the file was added and last modified).misc/whipper-uninstalled: A script to help run whipper without installing it. Not referenced anywhere and seems like something that Python virtual environments are perfectly suited for now. My vote is to either toss the script or rewrite it to usevirtualenv(leaning towards the former).