Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'whipper drive list' returns a suggestion to run 'rip offset find' #112

Closed
axelsimon opened this issue Jan 15, 2017 · 3 comments · Fixed by #114
Closed

'whipper drive list' returns a suggestion to run 'rip offset find' #112

axelsimon opened this issue Jan 15, 2017 · 3 comments · Fixed by #114
Assignees
@JoeLametta
Labels
Bug Generic bug: can be used together with more specific labels
Milestone
1.0

Comments

@axelsimon
Copy link

Hi,
Running whipper drive list returns a suggestion to run rip offset find instead of whipper offset find, causing it to fail if one follows the suggestion.

There are probably more in the code (after all, it's a fork, it's bound to happen) but I thought it might be worth mentioning :)

Hope this helps.
@JoeLametta JoeLametta added the Bug Generic bug: can be used together with more specific labels label Jan 15, 2017
@JoeLametta JoeLametta self-assigned this Jan 15, 2017
@JoeLametta JoeLametta added this to the 1.0 milestone Jan 15, 2017
@JoeLametta
Copy link
Collaborator

There are probably more in the code (after all, it's a fork, it's bound to happen) but I thought it might be worth mentioning :)

I'll check if there are other similar issues and fix them.

Hope this helps.

Sure, thanks for the bug report!

@JoeLametta
Copy link
Collaborator

I've checked and, apart from lots of strings in comments, I've found only two occurrences which I'm going to fix now.

JoeLametta added a commit that referenced this issue Jan 16, 2017
@JoeLametta
Replace rip command suggestions with whipper
0783425 
I've only fixed the user facing occurrences: there are lots more in the source code.

Fixes #112
@JoeLametta JoeLametta mentioned this issue Jan 16, 2017
Merged
@JoeLametta
Copy link
Collaborator

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeLametta JoeLametta

Labels
Bug Generic bug: can be used together with more specific labels
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Replace rip command suggestions with 'whipper' whipper-team/whipper
2 participants
@axelsimon @JoeLametta