Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include native-image files correctly #784

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

klopfdreh
Copy link
Contributor

@klopfdreh klopfdreh commented Sep 4, 2024

Fixes: #783

Hint: I added a new resource block with **/*.json as there may also be a reflect-config.json in future which might also be included.

Test result:
Bildschirmfoto 2024-09-04 um 06 04 35

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features
    • Added a new contributor, Tobias Soloschenko, to acknowledge their contributions.
    • Expanded resource management by including specific JSON files from a new directory in the build process.

These changes enhance project documentation and improve resource handling without affecting existing functionality.

Copy link

coderabbitai bot commented Sep 4, 2024

Walkthrough

Walkthrough

The changes made to the pom.xml file include the addition of a new contributor, Tobias Soloschenko, and the inclusion of a new resource entry that specifies a directory for a specific JSON file. These modifications enhance contributor recognition and expand the resource management within the build process.

Changes

Files Change Summary
pom.xml Added contributor entry for Tobias Soloschenko and a new resource entry for a specific JSON file in META-INF.

Assessment against linked issues

Objective Addressed Explanation
The file resources-config.json is not correctly copied from META-INF/native-image to target (#783)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4a1402a and 967a5ef.

Files selected for processing (1)
  • pom.xml (2 hunks)
Files skipped from review due to trivial changes (1)
  • pom.xml

@jodastephen
Copy link
Member

@coderabbitai Why do you say that "The file reflect-config.json is not correctly copied from META-INF/native-image to target"?

Copy link

coderabbitai bot commented Sep 5, 2024

Tip

For best results, initiate chat on the files or code changes.

@jodastephen The reason for the statement is that there were no existing configurations in the pom.xml file to handle the copying of reflect-config.json from META-INF/native-image to the target directory. The new changes in the PR, which add a <resource> entry to include JSON files from the META-INF directory, should now ensure that reflect-config.json is correctly included in the build output.

Analysis chain
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any existing configurations in the pom.xml file that handle the copying of files from META-INF/native-image to the target directory.
rg 'META-INF/native-image' -A 5 --glob '**/pom.xml'

Length of output: 51


Script:

#!/bin/bash
# Search for any references to reflect-config.json in the pom.xml file.
rg 'reflect-config.json' --glob '**/pom.xml'

Length of output: 44

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 967a5ef and 68ee5c1.

Files selected for processing (1)
  • pom.xml (2 hunks)
Files skipped from review due to trivial changes (1)
  • pom.xml

@klopfdreh
Copy link
Contributor Author

klopfdreh commented Sep 5, 2024

@jodastephen changes are made and force pushed as a single commit to merge them directly. 👍

@jodastephen jodastephen merged commit 038646b into JodaOrg:main Sep 7, 2024
4 checks passed
github-merge-queue bot referenced this pull request in camunda/camunda Sep 16, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [joda-time:joda-time](https://www.joda.org/joda-time/)
([source](https://redirect.github.com/JodaOrg/joda-time)) | `2.12.7` ->
`2.13.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/joda-time:joda-time/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/joda-time:joda-time/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/joda-time:joda-time/2.12.7/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/joda-time:joda-time/2.12.7/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>JodaOrg/joda-time (joda-time:joda-time)</summary>

###
[`v2.13.0`](https://redirect.github.com/JodaOrg/joda-time/releases/tag/v2.13.0)

[Compare
Source](https://redirect.github.com/JodaOrg/joda-time/compare/v2.12.7...v2.13.0)

See the [change
notes](https://www.joda.org/joda-time/changes-report.html#a2.13.0) for
more information.

#### What's Changed

- Make `ConverterManager.getInstance()` init thread-safe. by
[@&#8203;cpovirk](https://redirect.github.com/cpovirk) in
[https://github.com/JodaOrg/joda-time/pull/776](https://redirect.github.com/JodaOrg/joda-time/pull/776)
- Add website page about secutity/CVEs by
[@&#8203;jodastephen](https://redirect.github.com/jodastephen) in
[https://github.com/JodaOrg/joda-time/pull/781](https://redirect.github.com/JodaOrg/joda-time/pull/781)
- fix: include native-image files correctly by
[@&#8203;klopfdreh](https://redirect.github.com/klopfdreh) in
[https://github.com/JodaOrg/joda-time/pull/784](https://redirect.github.com/JodaOrg/joda-time/pull/784)
- Enhance TZDB compiler to better match spec by
[@&#8203;jodastephen](https://redirect.github.com/jodastephen) in
[https://github.com/JodaOrg/joda-time/pull/786](https://redirect.github.com/JodaOrg/joda-time/pull/786)
- Update GitHub actions to latest versions by
[@&#8203;jodastephen](https://redirect.github.com/jodastephen) in
[https://github.com/JodaOrg/joda-time/pull/788](https://redirect.github.com/JodaOrg/joda-time/pull/788)
- Fix TZDB compiler %z parsing by
[@&#8203;jodastephen](https://redirect.github.com/jodastephen) in
[https://github.com/JodaOrg/joda-time/pull/787](https://redirect.github.com/JodaOrg/joda-time/pull/787)
- Update tzdb handling by
[@&#8203;jodastephen](https://redirect.github.com/jodastephen) in
[https://github.com/JodaOrg/joda-time/pull/789](https://redirect.github.com/JodaOrg/joda-time/pull/789)
- Update time zone data to 2024bgtz by
[@&#8203;github-actions](https://redirect.github.com/github-actions) in
[https://github.com/JodaOrg/joda-time/pull/790](https://redirect.github.com/JodaOrg/joda-time/pull/790)

#### New Contributors

- [@&#8203;cpovirk](https://redirect.github.com/cpovirk) made their
first contribution in
[https://github.com/JodaOrg/joda-time/pull/776](https://redirect.github.com/JodaOrg/joda-time/pull/776)
- [@&#8203;klopfdreh](https://redirect.github.com/klopfdreh) made their
first contribution in
[https://github.com/JodaOrg/joda-time/pull/784](https://redirect.github.com/JodaOrg/joda-time/pull/784)

**Full Changelog**:
JodaOrg/joda-time@v2.12.7...v2.13.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/camunda/camunda).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXV0b21lcmdlIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

The file resources-config.json is not correctly copied from META-INF/native-image/* to target
2 participants