Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon mapping for new UI isn't working #105

Closed
rock3r opened this issue Aug 31, 2023 · 1 comment · Fixed by #112
Closed

Icon mapping for new UI isn't working #105

rock3r opened this issue Aug 31, 2023 · 1 comment · Fixed by #112
Assignees
@rock3r
Labels
bug Something isn't working
Milestone
Build 0.6.0 (mile...

Comments

@rock3r
Copy link
Collaborator

rock3r commented Aug 31, 2023

I implemented New UI Icon mapping (i.e., the mechanism that the IDE uses to map old UI icons to New UI icons — see this) in #102 but it fails. The app-level service IconMapLoader is complaining that the pre-loading isn't done yet, which is impossible since it's actually join()ed on in the IDE's init.

See commit 2bed34f
@rock3r rock3r added the bug Something isn't working label Aug 31, 2023
@rock3r rock3r added this to the Build 0.6.0 (milestone 6) milestone Aug 31, 2023
@rock3r
Copy link
Collaborator Author

rock3r commented Sep 5, 2023

The issue seems intermittent — I sometimes don't get any errors and it works fine. @lamba92 will be looking into it

@rock3r rock3r assigned rock3r and unassigned lamba92 Sep 7, 2023
@rock3r rock3r mentioned this issue Sep 15, 2023
Merged
@rock3r rock3r closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rock3r rock3r

Labels
bug Something isn't working
Projects
None yet
Milestone
Build 0.6.0 (milestone 6)
Development

Successfully merging a pull request may close this issue.

Fix icon loading in IDE JetBrains/jewel
2 participants
@rock3r @lamba92