Support for java.time.Instant for timestamp columns #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukas-krecan
force-pushed
the
master
branch
2 times, most recently
from
e77eb6a
to
b8f81d3
Compare
|
@lukas-krecan , thank you for a PR but could you kindly check failed tests here? |
We use Instant in our Kotlin code-base and it seems awkward to convert it to LocalDateTime when java.sql.Timestamp supports Instant directly
|
Tests fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Instant in our Koltin code-base and it seems awkward to convert it
to LocalDateTime when java.sql.Timestamp supports Instant directly