Skip to content

Commit

Permalink
Pull in vue-template-compiler on demand
Browse files Browse the repository at this point in the history
This will help avoid issues with vue-template-compiler version mismatch errors. The user should be in control of this dependency.
  • Loading branch information
JeffreyWay committed Dec 17, 2018
1 parent 85856a7 commit 531ab62
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 11 deletions.
16 changes: 9 additions & 7 deletions npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
"terser": "^3.11.0",
"terser-webpack-plugin": "^1.1.0",
"vue-loader": "^15.4.2",
"vue-template-compiler": "^2.5.13",
"webpack": "^4.27.1",
"webpack-cli": "^3.1.2",
"webpack-dev-server": "^3.1.10",
Expand Down Expand Up @@ -91,8 +90,9 @@
"sinon": "^7.1.1",
"stylus": "^0.54.5",
"stylus-loader": "^3.0.2",
"vue": "^2.5.13",
"vue-style-loader": "^4.0.2"
"vue": "^2.5.21",
"vue-style-loader": "^4.0.2",
"vue-template-compiler": "^2.5.21"
},
"engines": {
"node": ">=6.0.0"
Expand Down
6 changes: 5 additions & 1 deletion src/components/Vue.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,13 @@ class Vue {
* Required dependencies for the component.
*/
dependencies() {
let dependencies = ['vue-template-compiler'];

if (Config.extractVueStyles && Config.globalVueStyles) {
return ['sass-resources-loader'];
dependencies.push('sass-resources-loader');
}

return dependencies;
}

/**
Expand Down

0 comments on commit 531ab62

Please sign in to comment.