Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking an option after searching doesn't always close dropdown #470

Closed
abraham-chan opened this issue Sep 22, 2015 · 8 comments
Closed

Comments

@abraham-chan
Copy link

On the demo page on the States dropdown, search for "e".
Click "New South Wales" and the dropdown closes as expected.
Click "Queensland" and the dropdown stays open.

@wmf23
Copy link

wmf23 commented Sep 23, 2015

Yes, I see the same issue. I want to create a new items if it's not already in the list of options. If I click 'Add "my new item"?' then the dropdown does not close and shows the original options. However, if I press enter to create my new option then the dropdown goes away (as I would expect).

e.g. on the demo page if you go the 'Custom render options/values' select and type in 'a' and then click on 'Add "a"?', you see that the dropdown shows up.

@VadimMustyatsa
Copy link

We faced the same issue after implementing this control in our solution. On the demo page it reproduces too:

  • For 1 charater: 3rd+ item (searh for "e", click "Queensland"+)
  • For 2 characters: 2nd+ item (search for "li", click "Western Australia"+)
  • For 3 characters: 2nd+ item (search for "lia", click "Western Australia"+)

@RichardD012
Copy link

This seems to be a timing issue. If you pause in the chrome dev tools, and wait a few seconds, regardless of the option you pick, the menu stays open.

@romanonthego
Copy link

👍
we have the same problem

@romanonthego
Copy link

Please note that menu reopens only when:

  1. where is no value to begin with (if where is preselected value - everything is fine, you need to clear value to reproduce this issue)
  2. only on mouse click (tab+enter works well)
    oh, and it's in case of async functionality used.

@abraham-chan
Copy link
Author

Appears to be fixed?
@JedWatson was this resolved in 7684869 ?

@wmf23
Copy link

wmf23 commented Oct 6, 2015

Yes, seems to be fixed.

@JedWatson
Copy link
Owner

Thanks for picking that up @abraham-chan and @wmf23! I didn't realise that was the cause of this issue, was implementing it for best practice. Glad to know it works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants