Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken keyboard navigation on grouped selects during filtering #4421

Closed
dmarkow opened this issue Feb 4, 2021 · 1 comment · Fixed by #4422
Closed

Broken keyboard navigation on grouped selects during filtering #4421

dmarkow opened this issue Feb 4, 2021 · 1 comment · Fixed by #4422
Assignees
Labels
issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer issue/has-pr Issue has a PR attached to it that may solve the issue

Comments

@dmarkow
Copy link

dmarkow commented Feb 4, 2021

#4398 / v4.0.2 fixed some issues with up/down navigation in a grouped select. However, if you type into a grouped select to filter it, then try to use the arrows, it's not working correctly. The arrow keys appear to be navigating all of the unfiltered options rather than just the filtered ones. This only seems to affect grouped selects. The regular ungrouped ones navigate filtered options just fine.

To reproduce:

Using the same example based on 3.2.0 works as expected: https://codesandbox.io/s/codesandboxer-example-forked-uhw5d

@Methuselah96 Methuselah96 added the issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer label Feb 4, 2021
@Methuselah96 Methuselah96 self-assigned this Feb 4, 2021
@Methuselah96
Copy link
Collaborator

Methuselah96 commented Feb 4, 2021

🤦 That's pretty embarrassing. There was a bug in my bug-fix. Proper fix coming soon.

@ebonow ebonow added the issue/has-pr Issue has a PR attached to it that may solve the issue label Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer issue/has-pr Issue has a PR attached to it that may solve the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants