Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select component methods should be documented. #420

Closed
mik01aj opened this issue Aug 27, 2015 · 4 comments
Closed

Select component methods should be documented. #420

mik01aj opened this issue Aug 27, 2015 · 4 comments

Comments

@mik01aj
Copy link

mik01aj commented Aug 27, 2015

Looking at the source, the following methods seem useful to me:

  • focus (it is even used on the demo page!)
  • setValue
  • addValue
  • removeValue
  • popValue
  • clearValue
  • getInputNode

There is nothing about them in the README.

@brianreavis
Copy link
Collaborator

As far as I know, those methods are only meant to be used internally (apart from focus()). The others should be avoided and be accomplished via props (following React's way of doing things).

@mik01aj
Copy link
Author

mik01aj commented Aug 31, 2015

Not everything can be accomplished through props, please see #409.

@brianreavis
Copy link
Collaborator

At its current state, right – use of those methods you mentioned is an unfortunate hack around something that should be simple / achievable via props. My only point in that we shouldn't be documenting methods that aren't intended to be public (I'm not trying to invalidate #409).

@mik01aj
Copy link
Author

mik01aj commented Aug 31, 2015

Ok, I reopened #409 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants