Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Async doesn't accept filterOption #2808

Closed
nadeemkhedr opened this issue Jul 18, 2018 · 1 comment
Closed

[v2] Async doesn't accept filterOption #2808

nadeemkhedr opened this issue Jul 18, 2018 · 1 comment

Comments

@nadeemkhedr
Copy link

Not sure if its a bug or its a design decision, Async component in the proptypes expects filterOption but when it renders < SelectComponent> it always set it to null

filterOption={null}

If its a design decision to remove it, I can share why we do need it in our project, currently this is the only thing that is blocking me from upgrading

@JedWatson
Copy link
Owner

This was a specific decision, but I've realised that simply defaulting the prop would cover the same default behaviour I wanted while unblocking you - so I've implemented that in #2822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants