Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax highlight in editor is broken on Firefox 27+ #141

Closed
LouCypher opened this issue Nov 2, 2013 · 8 comments
Closed

Syntax highlight in editor is broken on Firefox 27+ #141

LouCypher opened this issue Nov 2, 2013 · 8 comments
Labels
bug

Comments

@LouCypher
Copy link
Contributor

It's using CodeMirror now.
https://bugzilla.mozilla.org/show_bug.cgi?id=919978
@LouCypher
Copy link
Contributor Author

Appearantly they moved the module in edit.js#L33 from resource:///modules/source-editor.jsm to resource:///modules/devtools/sourceeditor/source-editor.jsm

LouCypher added a commit to LouCypher/stylish that referenced this issue Nov 8, 2013
@LouCypher
Fixes issue stylish-userstyles#141
0eb891f
@LouCypher LouCypher mentioned this issue Nov 9, 2013
Closed
@JasonBarnabe
Copy link
Contributor

I'm not sure whether your pull request is making it use CodeMirror or making it use where they're hiding Orion now. I'm waiting on bug 724962 for documentation.

Your pull request does make it work for now though, so I'll include it, thanks!

@JasonBarnabe
Copy link
Contributor

Your pull request didn't catch the exception when neither file is available. I committed a modified version of your pull request at 531bd32

@JasonBarnabe JasonBarnabe mentioned this issue Nov 19, 2013
Closed
@LouCypher
Copy link
Contributor Author

No problem. Thanks.

@LouCypher
Copy link
Contributor Author

It's broken again on latest Aurora and Nightly.
They have removed source-editor module. 😓

@JasonBarnabe
Copy link
Contributor

96f0d96

@JasonBarnabe
Copy link
Contributor

See also #166 and #167.

@LouCypher
Copy link
Contributor Author

Thanks 🍻

@rmzelle rmzelle mentioned this issue Nov 4, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LouCypher @JasonBarnabe