Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made search button in Web search wider. Also skewed side panel titles to the left #8463

Merged
merged 5 commits into from
Jan 25, 2022

Conversation

dimitrisdimos00
Copy link
Contributor

Made search button in Web search wider. Also skewed side panel titles to the left
Before:
image
After:
image

Fixes #8397

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@@ -46,7 +45,7 @@ private void initialize() {
fetchers.itemsProperty().bind(viewModel.fetchersProperty());
fetchers.valueProperty().bindBidirectional(viewModel.selectedFetcherProperty());
fetchers.setMaxWidth(Double.POSITIVE_INFINITY);

// setAlignment(Pos.BASELINE_RIGHT);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Artifact from testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... Will fix that right now

Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Siedlerchr Siedlerchr merged commit 2c92eb0 into JabRef:main Jan 25, 2022
@dimitrisdimos00 dimitrisdimos00 deleted the fix-for-issue-8397 branch January 25, 2022 21:08
Siedlerchr added a commit that referenced this pull request Jan 27, 2022
* upstream/main:
  Made search button in Web search wider. Also skewed side panel titles to the left (#8463)
Siedlerchr added a commit that referenced this pull request Jan 28, 2022
* upstream/main: (24 commits)
  Support CrossRef in CSL styles (#8454)
  Update FUNDING.yml (#8473)
  Update to Javafx 17.02 (#8470)
  Made search button in Web search wider. Also skewed side panel titles to the left (#8463)
  Bump h2-mvstore from 2.0.206 to 2.1.210 in /buildSrc (#8458)
  Bump mariadb-java-client from 2.7.4 to 2.7.5 (#8457)
  Bump com.github.andygoossens.modernizer from 1.6.1 to 1.6.2 (#8459)
  Bump mockito-core from 4.2.0 to 4.3.0 (#8460)
  Bump xmlunit-matchers from 2.8.3 to 2.8.4 (#8461)
  Improve error handling for browser extension (#8432)
  New Crowdin updates (#8451)
  Fix library tab exception when saving prefs (#8450)
  Rename Groups interface into Groups (#8449)
  New Crowdin updates (#8445)
  update snap url
  Update bug_report.yml for 5.5
  Show development information\n\n+semver: minor
  Release v5.5
  Update journal abbrev list
  New Crowdin updates (#8439)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertically align Groups and Web search panel
3 participants