Fix preview settings not saved due to l10n

CHANGELOG.md

@@ -66,6 +66,7 @@ inserting new citations in a OpenOffic/LibreOffice document. [#6957](https://git
 - We fixed an issue, when pulling changes from shared database via shortcut caused creation of a new tech report [6867](https://github.com/JabRef/jabref/issues/6867)
 - We fixed an issue where the JabRef GUI does not highlight the "All entries" group on start-up [#6691](https://github.com/JabRef/jabref/issues/6691)
 - We fixed an issue where a custom dark theme was not applied to the entry preview tab [7068](https://github.com/JabRef/jabref/issues/7068)
+- We fixed an issue where modifications to the Custom preview layout in the preferences were not saved [#6447](https://github.com/JabRef/jabref/issues/6447)
 
 ### Removed
 

src/main/java/org/jabref/gui/preferences/PreviewTabViewModel.java

@@ -91,8 +91,9 @@ public PreviewTabViewModel(DialogService dialogService, PreferencesService prefe
         initialPreviewPreferences = preferences.getPreviewPreferences();
 
         sourceTextProperty.addListener((observable, oldValue, newValue) -> {
-            if (getCurrentLayout() instanceof TextBasedPreviewLayout) {
-                ((TextBasedPreviewLayout) getCurrentLayout()).setText(sourceTextProperty.getValue().replace("\n", "__NEWLINE__"));
+            var currentLayout = getCurrentLayout();
+            if (currentLayout instanceof TextBasedPreviewLayout) {
+                ((TextBasedPreviewLayout) currentLayout).setText(sourceTextProperty.getValue().replace("\n", "__NEWLINE__"));
             }
         });
 
@@ -112,6 +113,7 @@ public BooleanProperty showAsExtraTabProperty() {
         return showAsExtraTab;
     }
 
+    @Override
     public void setValues() {
         showAsExtraTab.set(initialPreviewPreferences.showPreviewAsExtraTab());
         chosenListProperty().getValue().clear();
@@ -164,23 +166,24 @@ public void refreshPreview() {
     }
 
     private PreviewLayout findLayoutByName(String name) {
-        return availableListProperty.getValue().stream().filter(layout -> layout.getName().equals(name))
+        return availableListProperty.getValue().stream().filter(layout -> layout.getInternalName().equals(name))
                                     .findAny()
-                                    .orElse(chosenListProperty.getValue().stream().filter(layout -> layout.getName().equals(name))
+                                    .orElse(chosenListProperty.getValue().stream().filter(layout -> layout.getInternalName().equals(name))
                                                               .findAny()
                                                               .orElse(null));
     }
 
     private PreviewLayout getCurrentLayout() {
         if (!chosenSelectionModelProperty.getValue().getSelectedItems().isEmpty()) {
             return chosenSelectionModelProperty.getValue().getSelectedItems().get(0);
+
         }
 
         if (!chosenListProperty.getValue().isEmpty()) {
             return chosenListProperty.getValue().get(0);
         }
 
-        PreviewLayout layout = findLayoutByName("Preview");
+        PreviewLayout layout = findLayoutByName(TextBasedPreviewLayout.NAME);
         if (layout == null) {
             layout = initialPreviewPreferences.getTextBasedPreviewLayout();
         }
@@ -196,7 +199,7 @@ public void storeSettings() {
             chosenListProperty.add(previewPreferences.getTextBasedPreviewLayout());
         }
 
-        PreviewLayout previewStyle = findLayoutByName("Preview");
+        PreviewLayout previewStyle = findLayoutByName(TextBasedPreviewLayout.NAME);
         if (previewStyle == null) {
             previewStyle = previewPreferences.getTextBasedPreviewLayout();
         }

src/main/java/org/jabref/logic/bst/BstPreviewLayout.java

@@ -80,4 +80,9 @@ public String generatePreview(BibEntry originalEntry, BibDatabase database) {
     public String getName() {
         return name;
     }
+
+    @Override
+    public String getInternalName() {
+        return name;
+    }
 }

src/main/java/org/jabref/logic/citationstyle/CitationStylePreviewLayout.java

@@ -5,7 +5,7 @@
 import org.jabref.model.entry.BibEntry;
 
 public class CitationStylePreviewLayout implements PreviewLayout {
-    private CitationStyle citationStyle;
+    private final CitationStyle citationStyle;
 
     public CitationStylePreviewLayout(CitationStyle citationStyle) {
         this.citationStyle = citationStyle;
@@ -28,4 +28,9 @@ public String getSource() {
     public String getFilePath() {
         return citationStyle.getFilePath();
     }
+
+    @Override
+    public String getInternalName() {
+        return citationStyle.getTitle();
+    }
 }

src/main/java/org/jabref/logic/layout/TextBasedPreviewLayout.java

@@ -15,8 +15,9 @@
  * Implements the preview based JabRef's <a href="https://docs.jabref.org/import-export/export/customexports">Custom export fitlters</a>.
  */
 public class TextBasedPreviewLayout implements PreviewLayout {
-    private static final Logger LOGGER = LoggerFactory.getLogger(TextBasedPreviewLayout.class);
+    public static final String NAME = "PREVIEW";
 
+    private static final Logger LOGGER = LoggerFactory.getLogger(TextBasedPreviewLayout.class);
     private Layout layout;
     private String text;
     private LayoutFormatterPreferences layoutFormatterPreferences;
@@ -54,6 +55,11 @@ public String getText() {
         return text;
     }
 
+    @Override
+    public String getInternalName() {
+        return NAME;
+    }
+
     @Override
     public String getName() {
         return Localization.lang("Customized preview style");

src/main/java/org/jabref/logic/preview/PreviewLayout.java

@@ -11,4 +11,6 @@ public interface PreviewLayout {
     String generatePreview(BibEntry entry, BibDatabase database);
 
     String getName();
+
+    String getInternalName();
 }