From 22f7b7ad178244bfe8843b2d511f1c97d9ec0f06 Mon Sep 17 00:00:00 2001 From: NivedhaSunderraj Date: Mon, 22 Oct 2018 07:29:56 +0530 Subject: [PATCH 1/2] Fixes for all mods exporter tests --- .../org/jabref/logic/exporter/ModsExportFormatTestFiles.java | 4 ++-- .../jabref/logic/exporter/ModsExportFormatTestAllFields.xml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/java/org/jabref/logic/exporter/ModsExportFormatTestFiles.java b/src/test/java/org/jabref/logic/exporter/ModsExportFormatTestFiles.java index 7a0d8ac6b6f..f7ca69a4ca6 100644 --- a/src/test/java/org/jabref/logic/exporter/ModsExportFormatTestFiles.java +++ b/src/test/java/org/jabref/logic/exporter/ModsExportFormatTestFiles.java @@ -71,7 +71,6 @@ public void setUp(@TempDirectory.TempDir Path testFolder) throws Exception { modsImporter = new ModsImporter(mock); } - @Disabled @ParameterizedTest @MethodSource("fileNames") public final void testPerformExport(String filename) throws Exception { @@ -89,6 +88,7 @@ public final void testPerformExport(String filename) throws Exception { .withNodeMatcher(new DefaultNodeMatcher(ElementSelectors.byNameAndText)).throwComparisonFailure()); } + @ParameterizedTest @MethodSource("fileNames") public final void testExportAsModsAndThenImportAsMods(String filename) throws Exception { @@ -99,7 +99,7 @@ public final void testExportAsModsAndThenImportAsMods(String filename) throws Ex BibEntryAssert.assertEquals(entries, tempFile, modsImporter); } - @Disabled + @ParameterizedTest @MethodSource("fileNames") public final void testImportAsModsAndExportAsMods(String filename) throws Exception { diff --git a/src/test/resources/org/jabref/logic/exporter/ModsExportFormatTestAllFields.xml b/src/test/resources/org/jabref/logic/exporter/ModsExportFormatTestAllFields.xml index f446f136049..15158f3323a 100644 --- a/src/test/resources/org/jabref/logic/exporter/ModsExportFormatTestAllFields.xml +++ b/src/test/resources/org/jabref/logic/exporter/ModsExportFormatTestAllFields.xml @@ -57,7 +57,7 @@ 2000-11-10 monographic - Verlag verlag + Verlag verlag From df1b55c280e4724264ee9111e0b6cdbc6ebdb051 Mon Sep 17 00:00:00 2001 From: NivedhaSunderraj Date: Mon, 22 Oct 2018 16:05:54 +0530 Subject: [PATCH 2/2] Removed unused import and empty lines --- .../org/jabref/logic/exporter/ModsExportFormatTestFiles.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/test/java/org/jabref/logic/exporter/ModsExportFormatTestFiles.java b/src/test/java/org/jabref/logic/exporter/ModsExportFormatTestFiles.java index f7ca69a4ca6..009c9f461ac 100644 --- a/src/test/java/org/jabref/logic/exporter/ModsExportFormatTestFiles.java +++ b/src/test/java/org/jabref/logic/exporter/ModsExportFormatTestFiles.java @@ -18,7 +18,6 @@ import org.jabref.model.util.DummyFileUpdateMonitor; import org.junit.jupiter.api.BeforeEach; -import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.extension.ExtendWith; import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.MethodSource; @@ -88,7 +87,6 @@ public final void testPerformExport(String filename) throws Exception { .withNodeMatcher(new DefaultNodeMatcher(ElementSelectors.byNameAndText)).throwComparisonFailure()); } - @ParameterizedTest @MethodSource("fileNames") public final void testExportAsModsAndThenImportAsMods(String filename) throws Exception { @@ -99,7 +97,6 @@ public final void testExportAsModsAndThenImportAsMods(String filename) throws Ex BibEntryAssert.assertEquals(entries, tempFile, modsImporter); } - @ParameterizedTest @MethodSource("fileNames") public final void testImportAsModsAndExportAsMods(String filename) throws Exception {