-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve unlinked files dialog #12195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun
, check the results, commit, and push.
You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".
src/test/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogViewModelTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codewise looks good already, just some small improvements.
will do a proper test tomorrow
src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogViewModel.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogViewModel.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogViewModelTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogViewModelTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogViewModelTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun
, check the results, commit, and push.
You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".
src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogViewModel.java
Show resolved
Hide resolved
src/test/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogViewModelTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun
, check the results, commit, and push.
You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".
src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogView.java
Outdated
Show resolved
Hide resolved
…n createEllipsisLabel method.
tested, looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the obvious comments from your AI-generated code (the code relays the information already) (or modify them to keep the useful parts).
We can merge after this.
Remember: If you are to spend time commenting - commenting the main code is always more important for developers than comments in the test class.
src/test/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogViewModelTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogViewModelTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogViewModelTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogViewModelTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogViewModelTest.java
Outdated
Show resolved
Hide resolved
* upstream/main: New Crowdin updates (#12264) New Crowdin updates (#12263) 11219 adapt UI font size (#12042) Added support for (biblatex) `langid` to be an optional field in entry editor (#12071) improve unlinked files dialog (#12195) Reword 0034-use-citation-key-for-grouping-chat-messages.md (#12183) Bump dev.langchain4j:langchain4j-open-ai from 0.36.0 to 0.36.2 (#12259) Bump io.zonky.test.postgres:embedded-postgres-binaries-bom (#12258) Bump tech.units:indriya from 2.2 to 2.2.1 (#12257) Bump org.jetbrains.kotlin:kotlin-stdlib-jdk8 from 2.0.21 to 2.1.0 (#12256) Bump io.github.classgraph:classgraph from 4.8.177 to 4.8.179 (#12255) Bump src/main/resources/csl-styles from `b90b81a` to `6b7b611` (#12254) Add hints on research (and BibTeX) to README.md (#12253) Disable non-working Openrewrite recipe always set maximized to false on exit for mac (#12248)
Description of changes:
I modified the display of file paths in the "File" column so that relative paths, starting from the directory specified in the "Directory" field, are shown instead of full absolute paths. I also added the ability to resize the columns in the table, making them customizable for the user. Additionally, I changed the alignment of the text in the column, which was previously aligned to the right, to the left, as described in the issue, to ensure proper display when the text doesn’t fit within the available space.
This change improves the clarity and flexibility when working with the table.
Closes #11878.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)