Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve unlinked files dialog #12195

Merged
merged 9 commits into from
Dec 2, 2024
Merged

Conversation

agondekova
Copy link
Contributor

Description of changes:

I modified the display of file paths in the "File" column so that relative paths, starting from the directory specified in the "Directory" field, are shown instead of full absolute paths. I also added the ability to resize the columns in the table, making them customizable for the user. Additionally, I changed the alignment of the text in the column, which was previously aligned to the right, to the left, as described in the issue, to ensure proper display when the text doesn’t fit within the available space.

This change improves the clarity and flexibility when working with the table.

Closes #11878.

relativePath columnResize

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun, check the results, commit, and push.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

@Siedlerchr Siedlerchr changed the title Fix for issue 11878 improve unlinked files dialog Nov 16, 2024
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codewise looks good already, just some small improvements.
will do a proper test tomorrow

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 16, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun, check the results, commit, and push.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

@calixtus calixtus added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Nov 24, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun, check the results, commit, and push.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

Siedlerchr
Siedlerchr previously approved these changes Dec 1, 2024
@Siedlerchr
Copy link
Member

tested, looks good

Copy link
Member

@subhramit subhramit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the obvious comments from your AI-generated code (the code relays the information already) (or modify them to keep the useful parts).
We can merge after this.

Remember: If you are to spend time commenting - commenting the main code is always more important for developers than comments in the test class.

@subhramit subhramit added component: ui and removed status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Dec 2, 2024
@Siedlerchr Siedlerchr enabled auto-merge December 2, 2024 19:34
@Siedlerchr Siedlerchr added this pull request to the merge queue Dec 2, 2024
Merged via the queue into JabRef:main with commit 17c3e2c Dec 2, 2024
24 checks passed
Siedlerchr added a commit that referenced this pull request Dec 6, 2024
* upstream/main:
  New Crowdin updates (#12264)
  New Crowdin updates (#12263)
  11219 adapt UI font size (#12042)
  Added support for (biblatex) `langid` to be an optional field in entry editor (#12071)
  improve unlinked files dialog (#12195)
  Reword 0034-use-citation-key-for-grouping-chat-messages.md (#12183)
  Bump dev.langchain4j:langchain4j-open-ai from 0.36.0 to 0.36.2 (#12259)
  Bump io.zonky.test.postgres:embedded-postgres-binaries-bom (#12258)
  Bump tech.units:indriya from 2.2 to 2.2.1 (#12257)
  Bump org.jetbrains.kotlin:kotlin-stdlib-jdk8 from 2.0.21 to 2.1.0 (#12256)
  Bump io.github.classgraph:classgraph from 4.8.177 to 4.8.179 (#12255)
  Bump src/main/resources/csl-styles from `b90b81a` to `6b7b611` (#12254)
  Add hints on research (and BibTeX) to README.md (#12253)
  Disable non-working Openrewrite recipe
  always set maximized  to false on exit for mac (#12248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lookup -> Search Unlinked local files: Improve dialog
6 participants