Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "After submission of a pull request" #12010

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Add "After submission of a pull request" #12010

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6605a90
Add "After submission of a pull request"
koppor Oct 17, 2024
92470e0
Fix space
koppor Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* [Getting a task assigned](#getting-a-task-assigned)
* [Pull Request Process](#pull-request-process)
* [Requirements on the pull request and code](#requirements-on-the-pull-request-and-code)
* [After submission of a pull request](#after-submission-of-a-pull-request)
* [Development hints](#development-hints)

## Choosing a task [![Join the chat at https://gitter.im/JabRef/jabref](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/JabRef/jabref)
Expand Down Expand Up @@ -126,6 +127,22 @@

We reserve the right to reject pull requests that contain little or no genuine and original contribution from the contributor.

### After submission of a pull request

After you submitted a pull request, automated checks will run.
You will maybe see "Some checks were not successful".

Check failure on line 133 in CONTRIBUTING.md

View workflow job for this annotation

GitHub Actions / Markdown

Trailing spaces 

CONTRIBUTING.md:133:54 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1] https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md009.md
Then, please look into them and handle accordingly.

Afterwards, you will receive comments on it.
Maybe, the pull request is approved immediatly, maybe changes are requested.
In case changes are requested, please implement them.

After changing your code, commit on the branch and push.
The pull request will update automatically.

Never ever close the pull request and open a new one.
This causes much load on our side and is not the style of the GitHub open source community.

### Development hints

#### When adding an external dependency
Expand Down
Loading