Fix issue no warning message for moving attached files

[juliusalberto]

Supersedes PR #11904

Closes #10121

Based on the feedback given on the above PR, I have introduced these changes:

1. In the org.jabref.logic.cleanup.MoveFilesCleanup, I collected a list of exceptions for each entry. These list of exceptions will then be stored by CleanupWorker. The CleanupAction will store every exceptions caused by IO errors, and will show it usingorg.jabref.gui.DialogService#showErrorDialogAndWait

Additional question: Should I create the tests as well?

Mandatory checks

• I own the copyright of the code submitted and I licence it under the MIT license
• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[github-actions]

Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun, check the results, commit, and push.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

[juliusalberto]

Hi @koppor (sorry if I mentioned you in the wrong place) - do you think this is already in line with the suggestion you wrote here: #11904 (review) ?

[koppor]

Normally we use the citaton key. You can use org.jabref.model.entry.BibEntry#getAuthorTitleYear(int) with 40 as maxCharacters as fallbeack.

[juliusalberto]

I deleted the citation key part as I think it'd be difficult passing both the entry and the exceptions from org.jabref.logic.cleanup.CleanupWorker to org.jabref.gui.cleanup.CleanupAction (I will have to create a wrapper to put the entry and its corresponding exceptions)

[koppor]

This is too early.

Do following:

1. Add method resetCleanUpFailures() to CleanupWorker
2. Add field `List failures to CleanupWorker
3. Add method getFailures() to CleanupWorker
4. Modify org.jabref.gui.cleanup.CleanupAction#cleanup to first resetCleanUpFailures, then iterate through the entries and then show the errors

While you are in resetCleanUpFailures, move the NamedCompund generation and ending outside of the loop - the cleanup of entries is a batch and should not be split.

[juliusalberto]

I am not sure why the resetCleanUpFailures() should be added to CleanupWorker when every time org.jabref.gui.cleanup.CleanupAction#doCleanup is called, the program will create a new CleanupWorker (and thus a new empty list of exceptions).

I assume that you meant to put the resetCleanupFailures in the org.jabref.gui.cleanup.CleanupAction, so the cleanupAction will store a list of exceptions.

[koppor]

Hi @koppor (sorry if I mentioned you in the wrong place) - do you think this is already in line with the suggestion you wrote here: #11904 (review) ?

Thank you for asking! We usually look into WIP PRs only if we are asked for. If you want to have reviews, ping us (as you did), change the PR state to "ready for review", or request review from someone using GitHubs functionality on the top right.