From 2164a67d31b9e667a85290686d304df3a9ea38ed Mon Sep 17 00:00:00 2001
From: "Ajita.Ganguly" <ajita.ganguly@cognizant.com>
Date: Sun, 25 Feb 2024 20:50:35 +0530
Subject: [PATCH 1/2] Add --next and previous buttons

---
 .../gui/importer/ImportEntriesDialog.fxml     |   5 +-
 .../gui/importer/ImportEntriesDialog.java     |  46 +++
 .../gui/importer/ImportEntriesViewModel.java  |   7 +
 .../gui/importer/WebImportEntriesDialog.fxml  |  66 ++++
 .../gui/importer/WebImportEntriesDialog.java  | 313 ++++++++++++++++++
 .../importer/WebimportEntriesViewmodel.java   | 286 ++++++++++++++++
 .../fetcher/WebSearchPaneViewModel.java       |   7 +-
 7 files changed, 726 insertions(+), 4 deletions(-)
 create mode 100644 src/main/java/org/jabref/gui/importer/WebImportEntriesDialog.fxml
 create mode 100644 src/main/java/org/jabref/gui/importer/WebImportEntriesDialog.java
 create mode 100644 src/main/java/org/jabref/gui/importer/WebimportEntriesViewmodel.java

diff --git a/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.fxml b/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.fxml
index 62e2427da77..1a445857419 100644
--- a/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.fxml
+++ b/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.fxml
@@ -14,7 +14,7 @@
 <?import javafx.scene.control.ComboBox?>
 <?import org.fxmisc.richtext.CodeArea?>
 <DialogPane prefHeight="700.0" prefWidth="1000.0" xmlns="http://javafx.com/javafx/10.0.2-internal"
-            xmlns:fx="http://javafx.com/fxml/1" fx:controller="org.jabref.gui.importer.ImportEntriesDialog">
+            xmlns:fx="http://javafx.com/fxml/1" fx:controller="org.jabref.gui.importer.WebImportEntriesDialog">
     <content>
         <VBox spacing="10.0">
             <Label text="%Select the entries to be imported:"/>
@@ -25,6 +25,9 @@
                         <Button onAction="#selectAllNewEntries"  text="%Select all new entries"/>
                         <Button onAction="#selectAllEntries"  text="%Select all entries"/>
                         <Button onAction="#unselectAll"  text="%Unselect all"/>
+                        <Button fx:id="previousButton"  text="Previous" />
+                        <Button fx:id="nextButton" text="Next" />
+<!--                        <Label fx:id="pageLabel"/>-->
                     </HBox>
                     <VBox fx:id="bibTeXDataBox" visible="false" managed="false">
                         <Label fx:id="bibTeXDataLabel"/>
diff --git a/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java b/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java
index 152df4e5446..7e934e6d9db 100644
--- a/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java
+++ b/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java
@@ -62,6 +62,10 @@ public class ImportEntriesDialog extends BaseDialog<Boolean> {
     public CheckListView<BibEntry> entriesListView;
     public ComboBox<BibDatabaseContext> libraryListView;
     public ButtonType importButton;
+    public Button previousButton;
+    public Button nextButton;
+    @FXML
+    public Label pageLabel;
     public Label totalItems;
     public Label selectedItems;
     public Label bibTeXDataLabel;
@@ -72,6 +76,9 @@ public class ImportEntriesDialog extends BaseDialog<Boolean> {
     private final BackgroundTask<ParserResult> task;
     private final BibDatabaseContext database;
     private ImportEntriesViewModel viewModel;
+    // private final int entriesPerPage = 20;
+   // private final ObservableList<BibEntry> allEntries;
+   // private final IntegerProperty currentPage = new SimpleIntegerProperty(1);
     @Inject private TaskExecutor taskExecutor;
     @Inject private DialogService dialogService;
     @Inject private UndoManager undoManager;
@@ -89,6 +96,7 @@ public class ImportEntriesDialog extends BaseDialog<Boolean> {
     public ImportEntriesDialog(BibDatabaseContext database, BackgroundTask<ParserResult> task) {
         this.database = database;
         this.task = task;
+      //  this.allEntries = FXCollections.observableArrayList();
         ViewLoader.view(this)
                   .load()
                   .setAsDialogPane(this);
@@ -99,6 +107,9 @@ public ImportEntriesDialog(BibDatabaseContext database, BackgroundTask<ParserRes
 
         downloadLinkedOnlineFiles.setSelected(preferences.getFilePreferences().shouldDownloadLinkedFiles());
 
+//        allEntries.addAll(database.getEntries());
+//        setEntries(Collections.emptyList());
+
         setResultConverter(button -> {
             if (button == importButton) {
                 viewModel.importEntries(entriesListView.getCheckModel().getCheckedItems(), downloadLinkedOnlineFiles.isSelected());
@@ -186,8 +197,32 @@ private void initialize() {
         totalItems.textProperty().bind(Bindings.size(entriesListView.getItems()).asString());
         entriesListView.setSelectionModel(new NoSelectionModel<>());
         initBibTeX();
+      //  addPagination();
     }
 
+//    public void setEntries(List<BibEntry> entries) {
+//        this.allEntries.setAll(entries);
+//        currentPage.set(1);
+//    }
+//
+//    public void addPagination() {
+//        previousButton.setOnAction(event -> {
+//            if (currentPage.get() > 1) {
+//                currentPage.set(currentPage.get() - 1);
+//            }
+//        });
+//
+//        nextButton.setOnAction(event -> {
+//            int totalPages = calculateTotalPages();
+//            if (currentPage.get() < totalPages) {
+//                currentPage.set(currentPage.get() + 1);
+//            }
+//        });
+//       currentPage.addListener(((observable, oldValue, newValue) -> updatePageEntries()));
+//
+//        updatePageEntries();
+//    }
+
     private void displayBibTeX(BibEntry entry, String bibTeX) {
         if (entriesListView.getCheckModel().isChecked(entry)) {
             bibTeXData.clear();
@@ -264,4 +299,15 @@ public void selectAllEntries() {
         unselectAll();
         entriesListView.getCheckModel().checkAll();
     }
+
+//    private void updatePageEntries() {
+//        int startIndex = (currentPage.get() - 1) * entriesPerPage;
+//        int endIndex = Math.min(startIndex + entriesPerPage, allEntries.size());
+//        this.entriesListView.setItems(FXCollections.observableArrayList(allEntries.subList(startIndex, endIndex)));
+//        pageLabel.setText(String.valueOf(currentPage.get()));
+//    }
+
+//    private int calculateTotalPages() {
+//        return (int) Math.ceil((double) allEntries.size() / entriesPerPage);
+//    }
 }
diff --git a/src/main/java/org/jabref/gui/importer/ImportEntriesViewModel.java b/src/main/java/org/jabref/gui/importer/ImportEntriesViewModel.java
index a0f926cf370..c93adbbe937 100644
--- a/src/main/java/org/jabref/gui/importer/ImportEntriesViewModel.java
+++ b/src/main/java/org/jabref/gui/importer/ImportEntriesViewModel.java
@@ -56,6 +56,7 @@ public class ImportEntriesViewModel extends AbstractViewModel {
     private final PreferencesService preferences;
     private final BibEntryTypesManager entryTypesManager;
     private final ObjectProperty<BibDatabaseContext> selectedDb;
+    // private final IntegerProperty totalNumberOfEntries = new SimpleIntegerProperty(0);
 
     /**
      * @param databaseContext the database to import into
@@ -95,6 +96,8 @@ public ImportEntriesViewModel(BackgroundTask<ParserResult> task,
             LOGGER.error("Error importing", ex);
             dialogService.showErrorDialogAndWait(ex);
         }).executeWith(taskExecutor);
+
+        // totalNumberOfEntries.set(getTotalNumberOfEntries());
     }
 
     public String getMessage() {
@@ -117,6 +120,10 @@ public ObservableList<BibEntry> getEntries() {
         return entries;
     }
 
+//    public int getTotalNumberOfEntries() {
+//        return databaseContext.getDatabase().getEntries().size();
+//    }
+
     public boolean hasDuplicate(BibEntry entry) {
         return findInternalDuplicate(entry).isPresent() ||
                 new DuplicateCheck(entryTypesManager)
diff --git a/src/main/java/org/jabref/gui/importer/WebImportEntriesDialog.fxml b/src/main/java/org/jabref/gui/importer/WebImportEntriesDialog.fxml
new file mode 100644
index 00000000000..81fa2f351ed
--- /dev/null
+++ b/src/main/java/org/jabref/gui/importer/WebImportEntriesDialog.fxml
@@ -0,0 +1,66 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<?import javafx.scene.control.Button?>
+<?import javafx.scene.control.ButtonType?>
+<?import javafx.scene.control.CheckBox?>
+<?import javafx.scene.control.DialogPane?>
+<?import javafx.scene.control.Label?>
+<?import javafx.scene.layout.ColumnConstraints?>
+<?import javafx.scene.layout.GridPane?>
+<?import javafx.scene.layout.HBox?>
+<?import javafx.scene.layout.RowConstraints?>
+<?import javafx.scene.layout.VBox?>
+<?import org.controlsfx.control.CheckListView?>
+<?import javafx.scene.control.ComboBox?>
+<?import org.fxmisc.richtext.CodeArea?>
+<DialogPane prefHeight="700.0" prefWidth="1000.0" xmlns="http://javafx.com/javafx/10.0.2-internal"
+            xmlns:fx="http://javafx.com/fxml/1" fx:controller="org.jabref.gui.importer.WebImportEntriesDialog">
+    <content>
+        <VBox spacing="10.0">
+            <Label text="%Select the entries to be imported:"/>
+            <CheckListView fx:id="entriesListView" VBox.vgrow="ALWAYS"/>
+            <HBox spacing="4">
+                <VBox spacing="10">
+                    <HBox spacing="4">
+                        <Button onAction="#selectAllNewEntries"  text="%Select all new entries"/>
+                        <Button onAction="#selectAllEntries"  text="%Select all entries"/>
+                        <Button onAction="#unselectAll"  text="%Unselect all"/>
+                        <Button fx:id="previousButton"  text="Previous" />
+                        <Button fx:id="nextButton" text="Next" />
+                        <Label fx:id="pageLabel"/>
+                    </HBox>
+                    <VBox fx:id="bibTeXDataBox" visible="false" managed="false">
+                        <Label fx:id="bibTeXDataLabel"/>
+                        <CodeArea fx:id="bibTeXData" editable="false" minHeight="30.0" prefHeight="200.0" prefWidth="700.0" wrapText="true"/>
+                    </VBox>
+                    <HBox spacing="4" alignment="CENTER_LEFT">
+                        <Label text="%Library to import into"/>
+                        <ComboBox fx:id="libraryListView" layoutX="16.0" layoutY="52.0"/>
+                    </HBox>
+                </VBox>
+                <HBox HBox.hgrow="ALWAYS"/>
+                <GridPane hgap="4.0" vgap="4.0">
+                    <columnConstraints>
+                        <ColumnConstraints hgrow="SOMETIMES"/>
+                        <ColumnConstraints hgrow="SOMETIMES" minWidth="30" halignment="RIGHT"/>
+                    </columnConstraints>
+                    <rowConstraints>
+                        <RowConstraints minHeight="10.0"/>
+                        <RowConstraints minHeight="10.0"/>
+                        <RowConstraints minHeight="10.0"/>
+                    </rowConstraints>
+                    <Label styleClass="info-section" text="%Total items found:"/>
+                    <Label fx:id="totalItems" GridPane.columnIndex="1"/>
+                    <Label styleClass="info-section" text="%Selected items:" GridPane.rowIndex="1"/>
+                    <Label fx:id="selectedItems" GridPane.rowIndex="1" GridPane.columnIndex="1"/>
+                </GridPane>
+            </HBox>
+            <HBox spacing="4">
+                <CheckBox fx:id="downloadLinkedOnlineFiles" text="%Download linked online files"/>
+                <CheckBox fx:id="showEntryInformation" text="%Show BibTeX source"/>
+            </HBox>
+        </VBox>
+    </content>
+    <ButtonType fx:id="importButton" buttonData="OK_DONE" text="%Import entries"/>
+    <ButtonType fx:constant="CANCEL"/>
+</DialogPane>
diff --git a/src/main/java/org/jabref/gui/importer/WebImportEntriesDialog.java b/src/main/java/org/jabref/gui/importer/WebImportEntriesDialog.java
new file mode 100644
index 00000000000..d9f9085a1a0
--- /dev/null
+++ b/src/main/java/org/jabref/gui/importer/WebImportEntriesDialog.java
@@ -0,0 +1,313 @@
+package org.jabref.gui.importer;
+
+import java.util.ArrayList;
+import java.util.EnumSet;
+import java.util.List;
+import java.util.Optional;
+
+import javax.swing.undo.UndoManager;
+
+import javafx.beans.binding.Bindings;
+import javafx.beans.binding.BooleanBinding;
+import javafx.beans.property.IntegerProperty;
+import javafx.beans.property.SimpleIntegerProperty;
+import javafx.collections.FXCollections;
+import javafx.collections.ObservableList;
+import javafx.css.PseudoClass;
+import javafx.fxml.FXML;
+import javafx.geometry.Insets;
+import javafx.scene.Node;
+import javafx.scene.control.Button;
+import javafx.scene.control.ButtonType;
+import javafx.scene.control.CheckBox;
+import javafx.scene.control.ComboBox;
+import javafx.scene.control.Label;
+import javafx.scene.control.ToggleButton;
+import javafx.scene.control.Tooltip;
+import javafx.scene.layout.Border;
+import javafx.scene.layout.BorderStroke;
+import javafx.scene.layout.BorderStrokeStyle;
+import javafx.scene.layout.BorderWidths;
+import javafx.scene.layout.CornerRadii;
+import javafx.scene.layout.HBox;
+import javafx.scene.layout.Priority;
+import javafx.scene.layout.VBox;
+import javafx.scene.paint.Color;
+import javafx.scene.text.Text;
+
+import org.jabref.gui.DialogService;
+import org.jabref.gui.StateManager;
+import org.jabref.gui.icon.IconTheme;
+import org.jabref.gui.util.BackgroundTask;
+import org.jabref.gui.util.BaseDialog;
+import org.jabref.gui.util.NoSelectionModel;
+import org.jabref.gui.util.TaskExecutor;
+import org.jabref.gui.util.TextFlowLimited;
+import org.jabref.gui.util.ViewModelListCellFactory;
+import org.jabref.logic.importer.ParserResult;
+import org.jabref.logic.l10n.Localization;
+import org.jabref.logic.shared.DatabaseLocation;
+import org.jabref.logic.util.io.FileUtil;
+import org.jabref.model.database.BibDatabaseContext;
+import org.jabref.model.entry.BibEntry;
+import org.jabref.model.entry.BibEntryTypesManager;
+import org.jabref.model.entry.field.StandardField;
+import org.jabref.model.entry.types.EntryType;
+import org.jabref.model.entry.types.StandardEntryType;
+import org.jabref.model.util.FileUpdateMonitor;
+import org.jabref.preferences.PreferencesService;
+
+import com.airhacks.afterburner.views.ViewLoader;
+import com.tobiasdiez.easybind.EasyBind;
+import jakarta.inject.Inject;
+import org.controlsfx.control.CheckListView;
+import org.fxmisc.richtext.CodeArea;
+
+public class WebImportEntriesDialog extends BaseDialog<Boolean> {
+    public CheckListView<BibEntry> entriesListView;
+    public ComboBox<BibDatabaseContext> libraryListView;
+    public ButtonType importButton;
+    public Button previousButton;
+    public Button nextButton;
+    @FXML
+    public Label pageLabel;
+    public Label totalItems;
+    public Label selectedItems;
+    public Label bibTeXDataLabel;
+    public CheckBox downloadLinkedOnlineFiles;
+    public CheckBox showEntryInformation;
+    public CodeArea bibTeXData;
+    public VBox bibTeXDataBox;
+    private final BackgroundTask<ParserResult> task;
+    private final BibDatabaseContext database;
+    private ImportEntriesViewModel viewModel;
+    private List<BibEntry> entries = new ArrayList<>();
+     private IntegerProperty currentPage;
+    @Inject private TaskExecutor taskExecutor;
+    @Inject private DialogService dialogService;
+    @Inject private UndoManager undoManager;
+    @Inject private PreferencesService preferences;
+    @Inject private StateManager stateManager;
+    @Inject private BibEntryTypesManager entryTypesManager;
+    @Inject private FileUpdateMonitor fileUpdateMonitor;
+
+    /**
+     * Imports the given entries into the given database. The entries are provided using the BackgroundTask
+     *
+     * @param database the database to import into
+     * @param task     the task executed for parsing the selected files(s).
+     */
+    public WebImportEntriesDialog(BibDatabaseContext database, BackgroundTask<ParserResult> task) {
+        this.database = database;
+        this.task = task;
+        this.currentPage = new SimpleIntegerProperty(1);
+        ViewLoader.view(this)
+                  .load()
+                  .setAsDialogPane(this);
+
+        task.onSuccess(parserResult -> {
+            entries = parserResult.getDatabase().getEntries();
+            setItemsForCurrentPage(currentPage.get(), 20);
+        });
+        previousButton.setOnAction(event -> {
+            if (currentPage.get() > 1) {
+                currentPage.set(currentPage.get() - 1);
+                setItemsForCurrentPage(currentPage.get(), 20);
+            }
+        });
+
+        nextButton.setOnAction(event -> {
+            int totalPages = (int) Math.ceil((double) entries.size() / 20);
+            if (currentPage.get() < totalPages) {
+                currentPage.set(currentPage.get() + 1);
+                setItemsForCurrentPage(currentPage.get(), 20);
+            }
+        });
+
+        task.executeWith(taskExecutor);
+
+        BooleanBinding booleanBind = Bindings.isEmpty(entriesListView.getCheckModel().getCheckedItems());
+        Button btn = (Button) this.getDialogPane().lookupButton(importButton);
+        btn.disableProperty().bind(booleanBind);
+        previousButton.disableProperty().bind(currentPage.lessThanOrEqualTo(1));
+
+        downloadLinkedOnlineFiles.setSelected(preferences.getFilePreferences().shouldDownloadLinkedFiles());
+
+        setResultConverter(button -> {
+            if (button == importButton) {
+                viewModel.importEntries(entriesListView.getCheckModel().getCheckedItems(), downloadLinkedOnlineFiles.isSelected());
+            } else {
+                dialogService.notify(Localization.lang("Import canceled"));
+            }
+
+            return false;
+        });
+    }
+
+    @FXML
+    private void initialize() {
+        viewModel = new ImportEntriesViewModel(task, taskExecutor, database, dialogService, undoManager, preferences, stateManager, entryTypesManager, fileUpdateMonitor);
+        Label placeholder = new Label();
+        placeholder.textProperty().bind(viewModel.messageProperty());
+        entriesListView.setPlaceholder(placeholder);
+        entriesListView.setItems(viewModel.getEntries());
+
+        libraryListView.setEditable(false);
+        libraryListView.getItems().addAll(stateManager.getOpenDatabases());
+        new ViewModelListCellFactory<BibDatabaseContext>()
+                .withText(database -> {
+                    Optional<String> dbOpt = Optional.empty();
+                    if (database.getDatabasePath().isPresent()) {
+                        dbOpt = FileUtil.getUniquePathFragment(stateManager.collectAllDatabasePaths(), database.getDatabasePath().get());
+                    }
+                    if (database.getLocation() == DatabaseLocation.SHARED) {
+                        return database.getDBMSSynchronizer().getDBName() + " [" + Localization.lang("shared") + "]";
+                    }
+
+                    return dbOpt.orElseGet(() -> Localization.lang("untitled"));
+                })
+                .install(libraryListView);
+        viewModel.selectedDbProperty().bind(libraryListView.getSelectionModel().selectedItemProperty());
+        stateManager.getActiveDatabase().ifPresent(database1 -> libraryListView.getSelectionModel().select(database1));
+
+        PseudoClass entrySelected = PseudoClass.getPseudoClass("entry-selected");
+        new ViewModelListCellFactory<BibEntry>()
+                .withGraphic(entry -> {
+                    ToggleButton addToggle = IconTheme.JabRefIcons.ADD.asToggleButton();
+                    EasyBind.subscribe(addToggle.selectedProperty(), selected -> {
+                        if (selected) {
+                            addToggle.setGraphic(IconTheme.JabRefIcons.ADD_FILLED.withColor(IconTheme.SELECTED_COLOR).getGraphicNode());
+                        } else {
+                            addToggle.setGraphic(IconTheme.JabRefIcons.ADD.getGraphicNode());
+                        }
+                    });
+                    addToggle.getStyleClass().add("addEntryButton");
+                    addToggle.selectedProperty().bindBidirectional(entriesListView.getItemBooleanProperty(entry));
+                    HBox separator = new HBox();
+                    HBox.setHgrow(separator, Priority.SOMETIMES);
+                    Node entryNode = getEntryNode(entry);
+                    HBox.setHgrow(entryNode, Priority.ALWAYS);
+                    HBox container = new HBox(entryNode, separator, addToggle);
+                    container.getStyleClass().add("entry-container");
+
+                    BackgroundTask.wrap(() -> viewModel.hasDuplicate(entry)).onSuccess(duplicateFound -> {
+                        if (duplicateFound) {
+                            Button duplicateButton = IconTheme.JabRefIcons.DUPLICATE.asButton();
+                            duplicateButton.setTooltip(new Tooltip(Localization.lang("Possible duplicate of existing entry. Click to resolve.")));
+                            duplicateButton.setOnAction(event -> viewModel.resolveDuplicate(entry));
+                            container.getChildren().add(1, duplicateButton);
+                        }
+                    }).executeWith(taskExecutor);
+
+                    /*
+                    inserted the if-statement here, since a Platform.runLater() call did not work.
+                    also tried to move it to the end of the initialize method, but it did not select the entry.
+                    */
+                    if (entriesListView.getItems().size() == 1) {
+                        selectAllNewEntries();
+                    }
+
+                    return container;
+                })
+                .withOnMouseClickedEvent((entry, event) -> {
+                    entriesListView.getCheckModel().toggleCheckState(entry);
+                    displayBibTeX(entry, viewModel.getSourceString(entry));
+                })
+                .withPseudoClass(entrySelected, entriesListView::getItemBooleanProperty)
+                .install(entriesListView);
+
+        selectedItems.textProperty().bind(Bindings.size(entriesListView.getCheckModel().getCheckedItems()).asString());
+        totalItems.textProperty().bind(Bindings.size(entriesListView.getItems()).asString());
+        entriesListView.setSelectionModel(new NoSelectionModel<>());
+        initBibTeX();
+    }
+
+    public void setItemsForCurrentPage(int pageNumber, int itemsPerPage) {
+        if (entries == null) {
+            return;
+        }
+       int startIndex = (pageNumber - 1) * itemsPerPage;
+        int endIndex = Math.min(startIndex + itemsPerPage, entries.size());
+        ObservableList<BibEntry> pageEntries = FXCollections.observableArrayList(entries.subList(startIndex, endIndex));
+        entriesListView.setItems(pageEntries);
+        int totalPages = (int) Math.ceil((double) entries.size() / itemsPerPage);
+        pageLabel.setText("Page " + pageNumber + " of " + totalPages);
+    }
+
+    private void displayBibTeX(BibEntry entry, String bibTeX) {
+        if (entriesListView.getCheckModel().isChecked(entry)) {
+            bibTeXData.clear();
+            bibTeXData.appendText(bibTeX);
+            bibTeXData.moveTo(0);
+            bibTeXData.requestFollowCaret();
+        } else {
+            bibTeXData.clear();
+        }
+    }
+
+    private void initBibTeX() {
+        bibTeXDataLabel.setText(Localization.lang("%0 source", "BibTeX"));
+        bibTeXData.setBorder(new Border(new BorderStroke(Color.GREY, BorderStrokeStyle.SOLID, CornerRadii.EMPTY, BorderWidths.DEFAULT)));
+        bibTeXData.setPadding(new Insets(5.0));
+        showEntryInformation.selectedProperty().addListener((observableValue, old_val, new_val) -> {
+            bibTeXDataBox.setVisible(new_val);
+            bibTeXDataBox.setManaged(new_val);
+        });
+    }
+
+    private Node getEntryNode(BibEntry entry) {
+        Node entryType = getIcon(entry.getType()).getGraphicNode();
+        entryType.getStyleClass().add("type");
+        Label authors = new Label(entry.getFieldOrAliasLatexFree(StandardField.AUTHOR).orElse(""));
+        authors.getStyleClass().add("authors");
+        Label title = new Label(entry.getFieldOrAliasLatexFree(StandardField.TITLE).orElse(""));
+        title.getStyleClass().add("title");
+        Label year = new Label(entry.getFieldOrAliasLatexFree(StandardField.YEAR).orElse(""));
+        year.getStyleClass().add("year");
+        Label journal = new Label(entry.getFieldOrAliasLatexFree(StandardField.JOURNAL).orElse(""));
+        journal.getStyleClass().add("journal");
+
+        VBox entryContainer = new VBox(
+                new HBox(10, entryType, title),
+                new HBox(5, year, journal),
+                authors
+        );
+        entry.getFieldOrAliasLatexFree(StandardField.ABSTRACT).ifPresent(summaryText -> {
+            TextFlowLimited summary = new TextFlowLimited(new Text(summaryText));
+            summary.getStyleClass().add("summary");
+            entryContainer.getChildren().add(summary);
+        });
+
+        entryContainer.getStyleClass().add("bibEntry");
+        return entryContainer;
+    }
+
+    private IconTheme.JabRefIcons getIcon(EntryType type) {
+        EnumSet<StandardEntryType> crossRefTypes = EnumSet.of(StandardEntryType.InBook, StandardEntryType.InProceedings, StandardEntryType.InCollection);
+        if (type == StandardEntryType.Book) {
+            return IconTheme.JabRefIcons.BOOK;
+        } else if (crossRefTypes.contains(type)) {
+            return IconTheme.JabRefIcons.OPEN_LINK;
+        }
+        return IconTheme.JabRefIcons.ARTICLE;
+    }
+
+    public void unselectAll() {
+        entriesListView.getCheckModel().clearChecks();
+    }
+
+    public void selectAllNewEntries() {
+        unselectAll();
+        for (BibEntry entry : entriesListView.getItems()) {
+            if (!viewModel.hasDuplicate(entry)) {
+                entriesListView.getCheckModel().check(entry);
+                displayBibTeX(entry, viewModel.getSourceString(entry));
+            }
+        }
+    }
+
+    public void selectAllEntries() {
+        unselectAll();
+        entriesListView.getCheckModel().checkAll();
+    }
+}
diff --git a/src/main/java/org/jabref/gui/importer/WebimportEntriesViewmodel.java b/src/main/java/org/jabref/gui/importer/WebimportEntriesViewmodel.java
new file mode 100644
index 00000000000..99054370dcd
--- /dev/null
+++ b/src/main/java/org/jabref/gui/importer/WebimportEntriesViewmodel.java
@@ -0,0 +1,286 @@
+package org.jabref.gui.importer;
+
+import java.io.IOException;
+import java.io.StringWriter;
+import java.util.List;
+import java.util.Optional;
+
+import javax.swing.undo.UndoManager;
+
+import javafx.beans.property.ObjectProperty;
+import javafx.beans.property.SimpleObjectProperty;
+import javafx.beans.property.SimpleStringProperty;
+import javafx.beans.property.StringProperty;
+import javafx.collections.FXCollections;
+import javafx.collections.ObservableList;
+
+import org.jabref.gui.AbstractViewModel;
+import org.jabref.gui.DialogService;
+import org.jabref.gui.StateManager;
+import org.jabref.gui.duplicationFinder.DuplicateResolverDialog;
+import org.jabref.gui.externalfiles.ImportHandler;
+import org.jabref.gui.fieldeditors.LinkedFileViewModel;
+import org.jabref.gui.util.BackgroundTask;
+import org.jabref.gui.util.TaskExecutor;
+import org.jabref.logic.bibtex.BibEntryWriter;
+import org.jabref.logic.bibtex.FieldWriter;
+import org.jabref.logic.database.DatabaseMerger;
+import org.jabref.logic.database.DuplicateCheck;
+import org.jabref.logic.exporter.BibWriter;
+import org.jabref.logic.importer.ParserResult;
+import org.jabref.logic.l10n.Localization;
+import org.jabref.logic.util.OS;
+import org.jabref.model.database.BibDatabaseContext;
+import org.jabref.model.entry.BibEntry;
+import org.jabref.model.entry.BibEntryTypesManager;
+import org.jabref.model.entry.LinkedFile;
+import org.jabref.model.util.FileUpdateMonitor;
+import org.jabref.preferences.PreferencesService;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class WebimportEntriesViewmodel extends AbstractViewModel {
+
+    private static final Logger LOGGER = LoggerFactory.getLogger(WebimportEntriesViewmodel.class);
+
+    private final StringProperty message;
+    private final TaskExecutor taskExecutor;
+    private final BibDatabaseContext databaseContext;
+    private final DialogService dialogService;
+    private final UndoManager undoManager;
+    private final StateManager stateManager;
+    private final FileUpdateMonitor fileUpdateMonitor;
+    private ParserResult parserResult = null;
+    private final ObservableList<BibEntry> entries;
+    private final PreferencesService preferences;
+    private final BibEntryTypesManager entryTypesManager;
+    private final ObjectProperty<BibDatabaseContext> selectedDb;
+
+    /**
+     * @param databaseContext the database to import into
+     * @param task            the task executed for parsing the selected files(s).
+     */
+    public WebimportEntriesViewmodel(BackgroundTask<ParserResult> task,
+                                  TaskExecutor taskExecutor,
+                                  BibDatabaseContext databaseContext,
+                                  DialogService dialogService,
+                                  UndoManager undoManager,
+                                  PreferencesService preferences,
+                                  StateManager stateManager,
+                                  BibEntryTypesManager entryTypesManager,
+                                  FileUpdateMonitor fileUpdateMonitor) {
+        this.taskExecutor = taskExecutor;
+        this.databaseContext = databaseContext;
+        this.dialogService = dialogService;
+        this.undoManager = undoManager;
+        this.preferences = preferences;
+        this.stateManager = stateManager;
+        this.entryTypesManager = entryTypesManager;
+        this.fileUpdateMonitor = fileUpdateMonitor;
+        this.entries = FXCollections.observableArrayList();
+        this.message = new SimpleStringProperty();
+        this.message.bind(task.messageProperty());
+        this.selectedDb = new SimpleObjectProperty<>();
+
+        task.onSuccess(parserResult -> {
+            // store the complete parser result (to import groups, ... later on)
+            this.parserResult = parserResult;
+            // fill in the list for the user, where one can select the entries to import
+            entries.addAll(parserResult.getDatabase().getEntries());
+            if (entries.isEmpty()) {
+                task.updateMessage(Localization.lang("No entries corresponding to given query"));
+            }
+        }).onFailure(ex -> {
+            LOGGER.error("Error importing", ex);
+            dialogService.showErrorDialogAndWait(ex);
+        }).executeWith(taskExecutor);
+    }
+
+    public String getMessage() {
+        return message.get();
+    }
+
+    public StringProperty messageProperty() {
+        return message;
+    }
+
+    public ObjectProperty<BibDatabaseContext> selectedDbProperty() {
+        return selectedDb;
+    }
+
+    public BibDatabaseContext getSelectedDb() {
+        return selectedDb.get();
+    }
+
+    public ObservableList<BibEntry> getEntries() {
+        return entries;
+    }
+
+    public boolean hasDuplicate(BibEntry entry) {
+        return findInternalDuplicate(entry).isPresent() ||
+                new DuplicateCheck(entryTypesManager)
+                        .containsDuplicate(selectedDb.getValue().getDatabase(), entry, selectedDb.getValue().getMode()).isPresent();
+    }
+
+    public String getSourceString(BibEntry entry) {
+        StringWriter writer = new StringWriter();
+        BibWriter bibWriter = new BibWriter(writer, OS.NEWLINE);
+        FieldWriter fieldWriter = FieldWriter.buildIgnoreHashes(preferences.getFieldPreferences());
+        try {
+            new BibEntryWriter(fieldWriter, entryTypesManager).write(entry, bibWriter, selectedDb.getValue().getMode());
+        } catch (
+                IOException ioException) {
+            return "";
+        }
+        return writer.toString();
+    }
+
+    /**
+     * Called after the user selected the entries to import. Does the real import stuff.
+     *
+     * @param entriesToImport subset of the entries contained in parserResult
+     */
+    public void importEntries(List<BibEntry> entriesToImport, boolean shouldDownloadFiles) {
+        // Check if we are supposed to warn about duplicates.
+        // If so, then see if there are duplicates, and warn if yes.
+        if (preferences.getImporterPreferences().shouldWarnAboutDuplicatesOnImport()) {
+            BackgroundTask.wrap(() -> entriesToImport.stream()
+                                                     .anyMatch(this::hasDuplicate)).onSuccess(duplicateFound -> {
+                if (duplicateFound) {
+                    boolean continueImport = dialogService.showConfirmationDialogWithOptOutAndWait(Localization.lang("Duplicates found"),
+                            Localization.lang("There are possible duplicates that haven't been resolved. Continue?"),
+                            Localization.lang("Continue with import"),
+                            Localization.lang("Cancel import"),
+                            Localization.lang("Do not ask again"),
+                            optOut -> preferences.getImporterPreferences().setWarnAboutDuplicatesOnImport(!optOut));
+
+                    if (!continueImport) {
+                        dialogService.notify(Localization.lang("Import canceled"));
+                    } else {
+                        buildImportHandlerThenImportEntries(entriesToImport);
+                    }
+                } else {
+                    buildImportHandlerThenImportEntries(entriesToImport);
+                }
+            }).executeWith(taskExecutor);
+        } else {
+            buildImportHandlerThenImportEntries(entriesToImport);
+        }
+
+        // Remember the selection in the dialog
+        preferences.getFilePreferences().setDownloadLinkedFiles(shouldDownloadFiles);
+
+        if (shouldDownloadFiles) {
+            for (BibEntry bibEntry : entriesToImport) {
+                bibEntry.getFiles().stream().filter(LinkedFile::isOnlineLink).forEach(linkedFile ->
+                        new LinkedFileViewModel(
+                                linkedFile,
+                                bibEntry,
+                                databaseContext,
+                                taskExecutor,
+                                dialogService,
+                                preferences).download());
+            }
+        }
+
+        new DatabaseMerger(preferences.getBibEntryPreferences().getKeywordSeparator()).mergeStrings(
+                databaseContext.getDatabase(),
+                parserResult.getDatabase());
+        new DatabaseMerger(preferences.getBibEntryPreferences().getKeywordSeparator()).mergeMetaData(
+                databaseContext.getMetaData(),
+                parserResult.getMetaData(),
+                parserResult.getPath().map(path -> path.getFileName().toString()).orElse("unknown"),
+                parserResult.getDatabase().getEntries());
+
+//        JabRefGUI.getMainFrame().getCurrentLibraryTab().markBaseChanged();
+    }
+
+    private void buildImportHandlerThenImportEntries(List<BibEntry> entriesToImport) {
+        ImportHandler importHandler = new ImportHandler(
+                selectedDb.getValue(),
+                preferences,
+                fileUpdateMonitor,
+                undoManager,
+                stateManager,
+                dialogService,
+                taskExecutor);
+        importHandler.importEntries(entriesToImport);
+        dialogService.notify(Localization.lang("Number of entries successfully imported") + ": " + entriesToImport.size());
+    }
+
+    /**
+     * Checks if there are duplicates to the given entry in the list of entries to be imported.
+     *
+     * @param entry The entry to search for duplicates of.
+     * @return A possible duplicate, if any, or null if none were found.
+     */
+    private Optional<BibEntry> findInternalDuplicate(BibEntry entry) {
+        for (BibEntry othEntry : entries) {
+            if (othEntry.equals(entry)) {
+                continue; // Don't compare the entry to itself
+            }
+            if (new DuplicateCheck(entryTypesManager).isDuplicate(entry, othEntry, databaseContext.getMode())) {
+                return Optional.of(othEntry);
+            }
+        }
+        return Optional.empty();
+    }
+
+    public void resolveDuplicate(BibEntry entry) {
+        // First, try to find duplicate in the existing library
+        Optional<BibEntry> other = new DuplicateCheck(entryTypesManager).containsDuplicate(databaseContext.getDatabase(), entry, databaseContext.getMode());
+        if (other.isPresent()) {
+            DuplicateResolverDialog dialog = new DuplicateResolverDialog(other.get(),
+                    entry, DuplicateResolverDialog.DuplicateResolverType.IMPORT_CHECK, databaseContext, stateManager, dialogService, preferences);
+
+            DuplicateResolverDialog.DuplicateResolverResult result = dialogService.showCustomDialogAndWait(dialog)
+                                                                                  .orElse(DuplicateResolverDialog.DuplicateResolverResult.BREAK);
+
+            if (result == DuplicateResolverDialog.DuplicateResolverResult.KEEP_LEFT) {
+                // TODO: Remove old entry. Or... add it to a list of entries
+                // to be deleted. We only delete
+                // it after Ok is clicked.
+                // entriesToDelete.add(other.get());
+            } else if (result == DuplicateResolverDialog.DuplicateResolverResult.KEEP_RIGHT) {
+                // Remove the entry from the import inspection dialog.
+                entries.remove(entry);
+            } else if (result == DuplicateResolverDialog.DuplicateResolverResult.KEEP_BOTH) {
+                // Do nothing.
+            } else if (result == DuplicateResolverDialog.DuplicateResolverResult.KEEP_MERGE) {
+                // TODO: Remove old entry. Or... add it to a list of entries
+                // to be deleted. We only delete
+                // it after Ok is clicked.
+                // entriesToDelete.add(other.get());
+
+                // Replace entry by merged entry
+                entries.add(dialog.getMergedEntry());
+                entries.remove(entry);
+            }
+            return;
+        }
+        // Second, check if the duplicate is of another entry in the import:
+        other = findInternalDuplicate(entry);
+        if (other.isPresent()) {
+            DuplicateResolverDialog diag = new DuplicateResolverDialog(entry,
+                    other.get(), DuplicateResolverDialog.DuplicateResolverType.DUPLICATE_SEARCH, databaseContext, stateManager, dialogService, preferences);
+
+            DuplicateResolverDialog.DuplicateResolverResult answer = dialogService.showCustomDialogAndWait(diag)
+                                                                                  .orElse(DuplicateResolverDialog.DuplicateResolverResult.BREAK);
+            if (answer == DuplicateResolverDialog.DuplicateResolverResult.KEEP_LEFT) {
+                // Remove other entry
+                entries.remove(other.get());
+            } else if (answer == DuplicateResolverDialog.DuplicateResolverResult.KEEP_RIGHT) {
+                // Remove entry
+                entries.remove(entry);
+            } else if (answer == DuplicateResolverDialog.DuplicateResolverResult.KEEP_BOTH) {
+                // Do nothing
+            } else if (answer == DuplicateResolverDialog.DuplicateResolverResult.KEEP_MERGE) {
+                // Replace both entries by merged entry
+                entries.add(diag.getMergedEntry());
+                entries.remove(entry);
+                entries.remove(other.get());
+            }
+        }
+    }
+}
diff --git a/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java b/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java
index 985bede5b5a..ec3d2d9e0d8 100644
--- a/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java
+++ b/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java
@@ -15,7 +15,7 @@
 import org.jabref.gui.DialogService;
 import org.jabref.gui.StateManager;
 import org.jabref.gui.Telemetry;
-import org.jabref.gui.importer.ImportEntriesDialog;
+import org.jabref.gui.importer.WebImportEntriesDialog;
 import org.jabref.gui.util.BackgroundTask;
 import org.jabref.logic.importer.CompositeIdFetcher;
 import org.jabref.logic.importer.ParserResult;
@@ -47,7 +47,6 @@ public class WebSearchPaneViewModel {
     private final DialogService dialogService;
     private final PreferencesService preferencesService;
     private final StateManager stateManager;
-
     private final Validator searchQueryValidator;
     private final SyntaxParser parser = new StandardSyntaxParser();
 
@@ -68,6 +67,7 @@ public WebSearchPaneViewModel(PreferencesService preferencesService, DialogServi
         } else {
             selectedFetcherProperty().setValue(fetchers.get(defaultFetcherIndex));
         }
+
         EasyBind.subscribe(selectedFetcherProperty(), newFetcher -> {
             int newIndex = fetchers.indexOf(newFetcher);
             sidePanePreferences.setWebSearchFetcherSelected(newIndex);
@@ -163,8 +163,9 @@ public void search() {
                              .withInitialMessage(Localization.lang("Processing %0", query));
         task.onFailure(dialogService::showErrorDialogAndWait);
 
-        ImportEntriesDialog dialog = new ImportEntriesDialog(stateManager.getActiveDatabase().get(), task);
+        WebImportEntriesDialog dialog = new WebImportEntriesDialog(stateManager.getActiveDatabase().get(), task);
         dialog.setTitle(finalFetcherName);
+
         dialogService.showCustomDialogAndWait(dialog);
     }
 

From a32174841ee975189d43aae1c788db3c5f69701b Mon Sep 17 00:00:00 2001
From: "Ajita.Ganguly" <ajita.ganguly@cognizant.com>
Date: Sun, 25 Feb 2024 21:05:52 +0530
Subject: [PATCH 2/2] Remove --comments

---
 .../gui/importer/ImportEntriesDialog.fxml     |  6 +--
 .../gui/importer/ImportEntriesDialog.java     | 46 -------------------
 .../gui/importer/ImportEntriesViewModel.java  |  9 ----
 3 files changed, 2 insertions(+), 59 deletions(-)

diff --git a/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.fxml b/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.fxml
index 1a445857419..9a010f485ad 100644
--- a/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.fxml
+++ b/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.fxml
@@ -14,7 +14,7 @@
 <?import javafx.scene.control.ComboBox?>
 <?import org.fxmisc.richtext.CodeArea?>
 <DialogPane prefHeight="700.0" prefWidth="1000.0" xmlns="http://javafx.com/javafx/10.0.2-internal"
-            xmlns:fx="http://javafx.com/fxml/1" fx:controller="org.jabref.gui.importer.WebImportEntriesDialog">
+            xmlns:fx="http://javafx.com/fxml/1" fx:controller="org.jabref.gui.importer.ImportEntriesDialog">
     <content>
         <VBox spacing="10.0">
             <Label text="%Select the entries to be imported:"/>
@@ -25,9 +25,7 @@
                         <Button onAction="#selectAllNewEntries"  text="%Select all new entries"/>
                         <Button onAction="#selectAllEntries"  text="%Select all entries"/>
                         <Button onAction="#unselectAll"  text="%Unselect all"/>
-                        <Button fx:id="previousButton"  text="Previous" />
-                        <Button fx:id="nextButton" text="Next" />
-<!--                        <Label fx:id="pageLabel"/>-->
+
                     </HBox>
                     <VBox fx:id="bibTeXDataBox" visible="false" managed="false">
                         <Label fx:id="bibTeXDataLabel"/>
diff --git a/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java b/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java
index 7e934e6d9db..152df4e5446 100644
--- a/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java
+++ b/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java
@@ -62,10 +62,6 @@ public class ImportEntriesDialog extends BaseDialog<Boolean> {
     public CheckListView<BibEntry> entriesListView;
     public ComboBox<BibDatabaseContext> libraryListView;
     public ButtonType importButton;
-    public Button previousButton;
-    public Button nextButton;
-    @FXML
-    public Label pageLabel;
     public Label totalItems;
     public Label selectedItems;
     public Label bibTeXDataLabel;
@@ -76,9 +72,6 @@ public class ImportEntriesDialog extends BaseDialog<Boolean> {
     private final BackgroundTask<ParserResult> task;
     private final BibDatabaseContext database;
     private ImportEntriesViewModel viewModel;
-    // private final int entriesPerPage = 20;
-   // private final ObservableList<BibEntry> allEntries;
-   // private final IntegerProperty currentPage = new SimpleIntegerProperty(1);
     @Inject private TaskExecutor taskExecutor;
     @Inject private DialogService dialogService;
     @Inject private UndoManager undoManager;
@@ -96,7 +89,6 @@ public class ImportEntriesDialog extends BaseDialog<Boolean> {
     public ImportEntriesDialog(BibDatabaseContext database, BackgroundTask<ParserResult> task) {
         this.database = database;
         this.task = task;
-      //  this.allEntries = FXCollections.observableArrayList();
         ViewLoader.view(this)
                   .load()
                   .setAsDialogPane(this);
@@ -107,9 +99,6 @@ public ImportEntriesDialog(BibDatabaseContext database, BackgroundTask<ParserRes
 
         downloadLinkedOnlineFiles.setSelected(preferences.getFilePreferences().shouldDownloadLinkedFiles());
 
-//        allEntries.addAll(database.getEntries());
-//        setEntries(Collections.emptyList());
-
         setResultConverter(button -> {
             if (button == importButton) {
                 viewModel.importEntries(entriesListView.getCheckModel().getCheckedItems(), downloadLinkedOnlineFiles.isSelected());
@@ -197,32 +186,8 @@ private void initialize() {
         totalItems.textProperty().bind(Bindings.size(entriesListView.getItems()).asString());
         entriesListView.setSelectionModel(new NoSelectionModel<>());
         initBibTeX();
-      //  addPagination();
     }
 
-//    public void setEntries(List<BibEntry> entries) {
-//        this.allEntries.setAll(entries);
-//        currentPage.set(1);
-//    }
-//
-//    public void addPagination() {
-//        previousButton.setOnAction(event -> {
-//            if (currentPage.get() > 1) {
-//                currentPage.set(currentPage.get() - 1);
-//            }
-//        });
-//
-//        nextButton.setOnAction(event -> {
-//            int totalPages = calculateTotalPages();
-//            if (currentPage.get() < totalPages) {
-//                currentPage.set(currentPage.get() + 1);
-//            }
-//        });
-//       currentPage.addListener(((observable, oldValue, newValue) -> updatePageEntries()));
-//
-//        updatePageEntries();
-//    }
-
     private void displayBibTeX(BibEntry entry, String bibTeX) {
         if (entriesListView.getCheckModel().isChecked(entry)) {
             bibTeXData.clear();
@@ -299,15 +264,4 @@ public void selectAllEntries() {
         unselectAll();
         entriesListView.getCheckModel().checkAll();
     }
-
-//    private void updatePageEntries() {
-//        int startIndex = (currentPage.get() - 1) * entriesPerPage;
-//        int endIndex = Math.min(startIndex + entriesPerPage, allEntries.size());
-//        this.entriesListView.setItems(FXCollections.observableArrayList(allEntries.subList(startIndex, endIndex)));
-//        pageLabel.setText(String.valueOf(currentPage.get()));
-//    }
-
-//    private int calculateTotalPages() {
-//        return (int) Math.ceil((double) allEntries.size() / entriesPerPage);
-//    }
 }
diff --git a/src/main/java/org/jabref/gui/importer/ImportEntriesViewModel.java b/src/main/java/org/jabref/gui/importer/ImportEntriesViewModel.java
index c93adbbe937..f24bc94ecd9 100644
--- a/src/main/java/org/jabref/gui/importer/ImportEntriesViewModel.java
+++ b/src/main/java/org/jabref/gui/importer/ImportEntriesViewModel.java
@@ -56,7 +56,6 @@ public class ImportEntriesViewModel extends AbstractViewModel {
     private final PreferencesService preferences;
     private final BibEntryTypesManager entryTypesManager;
     private final ObjectProperty<BibDatabaseContext> selectedDb;
-    // private final IntegerProperty totalNumberOfEntries = new SimpleIntegerProperty(0);
 
     /**
      * @param databaseContext the database to import into
@@ -96,8 +95,6 @@ public ImportEntriesViewModel(BackgroundTask<ParserResult> task,
             LOGGER.error("Error importing", ex);
             dialogService.showErrorDialogAndWait(ex);
         }).executeWith(taskExecutor);
-
-        // totalNumberOfEntries.set(getTotalNumberOfEntries());
     }
 
     public String getMessage() {
@@ -120,10 +117,6 @@ public ObservableList<BibEntry> getEntries() {
         return entries;
     }
 
-//    public int getTotalNumberOfEntries() {
-//        return databaseContext.getDatabase().getEntries().size();
-//    }
-
     public boolean hasDuplicate(BibEntry entry) {
         return findInternalDuplicate(entry).isPresent() ||
                 new DuplicateCheck(entryTypesManager)
@@ -199,8 +192,6 @@ public void importEntries(List<BibEntry> entriesToImport, boolean shouldDownload
                 parserResult.getMetaData(),
                 parserResult.getPath().map(path -> path.getFileName().toString()).orElse("unknown"),
                 parserResult.getDatabase().getEntries());
-
-//        JabRefGUI.getMainFrame().getCurrentLibraryTab().markBaseChanged();
     }
 
     private void buildImportHandlerThenImportEntries(List<BibEntry> entriesToImport) {