Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default save order should be "Keep original order" #8133

Closed
2 tasks done
koppor opened this issue Oct 9, 2021 · 8 comments · Fixed by #8229
Closed
2 tasks done

Default save order should be "Keep original order" #8133

koppor opened this issue Oct 9, 2021 · 8 comments · Fixed by #8229
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: enhancement
Milestone

Comments

@koppor
Copy link
Member

koppor commented Oct 9, 2021

JabRef version

5.3 (latest release)

Operating system

Windows

Details on version and operating system

Windows 10

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Create tst.bib with following content
@inproceedings{reiser2009compositional,
  title={Compositional variability-concepts and patterns},
  author={Reiser, M-O and Kolagari, Ramin Tavakoli and Weber, Matthias},
  booktitle={2009 42nd Hawaii International Conference on System Sciences},
  pages={1--10},
  year={2009},
  organization={IEEE}
}

@inproceedings{altintas2008managing,
  title={Managing large scale reuse across multiple software product lines},
  author={Altintas, N Ilker and Cetin, Semih},
  booktitle={International Conference on Software Reuse},
  pages={166--177},
  year={2008},
  organization={Springer}
}
  1. Save the .bib file
  2. JabRef adds % Encoding: UTF-8 and jabref-meta for the databaseType
    image
  3. Open "Library preferences"
  4. Set pdfs\ as file path
    image
  5. Save the library
  6. Result in JabRef:
    image
  7. Result in the bib file
    image

Expected results:

  • no change of the entry order.
  • No "The library has been modified by another program."

Proposed solution: Set "Keep original order" as default in the "Library properties":

image

For the "externally modified", there is issue #8132

Appendix

No response

@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Oct 9, 2021
@koppor koppor added this to the v5.4 milestone Oct 9, 2021
@koppor
Copy link
Member Author

koppor commented Oct 9, 2021

I put it to the milestone, because the default behavior could surprise new users.

I also put "good first issue" as it is IMHO not too complicated to change the default.

@koppor koppor assigned ghost Oct 10, 2021
@koppor
Copy link
Member Author

koppor commented Oct 10, 2021

@ManishOffi Sure. Please ensure that you follow https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace before working on this. 🎉

@ghost ghost removed their assignment Oct 11, 2021
@koppor
Copy link
Member Author

koppor commented Oct 13, 2021

I think, I have clean JabRef installation. There, at "Import and Export", the "Export sort order" is set to "Use current able sort order". We discussed in a devcall, that this is OK. However, this should not be used as default for the library properties.

grafik

@sjHong645
Copy link
Contributor

I want to do this issue. Is it okay??

@koppor
Copy link
Member Author

koppor commented Nov 3, 2021

I get this output

WARN org.jabref.model.metadata.SaveOrderConfig - Could not parse sort order: specified - trying to parse the sort criteria

@koppor
Copy link
Member Author

koppor commented Nov 3, 2021

@sponbob-pat Sure. Please ensure that you follow https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace before working on this. 🎉

@koppor
Copy link
Member Author

koppor commented Nov 3, 2021

This is closely related to #8198 (if not the same issue)

@sjHong645
Copy link
Contributor

Could you assign me?

@ghost ghost deleted a comment Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants