Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlinked files Importer: Continue (fall-through) when individual files fail to be processed #7206

Closed
7 tasks
koobs opened this issue Dec 18, 2020 · 2 comments · Fixed by #7209
Closed
7 tasks

Comments

@koobs
Copy link

koobs commented Dec 18, 2020

Is your suggestion for improvement related to a problem? Please describe.

When a user is attempting to import a "not small" (>1) number of files and the import process is completely stopped due to a single or small number of errors, the followings impacts present themselves:

  • The user is confused as to the state of the import, and library as a whole
  • The user must elect to either delete the successfully processed items from the library and start again, or identify the respective filenames from the next Scan/Import cycle, and exclude them. The impact is compounded because:
    1. the Import scan default selects all folders/items by default, AND
    2. The main window can displays titles (not filenames), and the Import dialog displays filenames, so they are difficult to match
  • While a traceback may be provided, it is difficult and time consuming to identify the respective source (file) of the error.
  • The failure of individual items should not affect or impact the ability to process other items.

Given arbitrary file processing can result in very many failures (and/or exceptions), Import file processing should not be fatal in these cases, and instead fall-through (skip and continue processing), notifying the user of the issue and ideally retaining the debug information (details of the issue), so that users can continue to report them.

Describe the solution you'd like

  • Change Import file processing to fall-through when unable to process a file, AND

Notify the user of files unable to be processed:

  • Mark the file that fails to be processed in the Import dialog tree control (file child elements), OR
  • Create an area in the Import dialog that can contain file processing information, that contains:
    • The full path of the filename with the issue, AND
    • The error message summary, AND
    • A traceback or details link or button to view the full traceback or log, OR
  • Create a dedicated "Processing Import" dialog that creates an entry per item (which also facilitates a "visual progress mechanism, see: Importer: JabRef stops responding (hangs) during PDF Import #7205 "add a visual progress mechanism to the Import dialog")

Additional context

@Siedlerchr Siedlerchr changed the title Importer: Continue (fall-through) when individual files fail to be processed Unlinked files Importer: Continue (fall-through) when individual files fail to be processed Dec 22, 2020
@Siedlerchr
Copy link
Member

I am currently reworking the dialog and I thought about marking/showing a similar dialog as in the copy files dialog (Tools -> Copy linked files to folder)
grafik

@ThiloteE
Copy link
Member

ThiloteE commented Dec 7, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants