Double key binding for inserting new TechReport and pulling changes from shared database

[m-mauersberger]

JabRef version 5.2 on openSUSE Leap 15.1

• Mandatory: I have tested the latest development version from http://builds.jabref.org/master/ and the problem persists

Steps to reproduce the behavior:

1. Open a shared database.
2. Press "Ctrl+Shift+R".
3. Changes from shared database are pulled and a new TechReport is inserted.

Maybe this is quickly done... ;)

[Gena928]

Just realised this bug does not depend on Shared Database.
I.e. you can open any library, press "Ctrl+Shift+R" and a new TechReport will be inserted.

I'll try to fix that.

[Gena928]

@tobiasdiez
need an advice. ))) Looks like there are 2 actions on "ctrl+shift+R" key combination:

• pull changes from shared database;
• create new technical report;

I see it in KeyBinding.java file. Which one is better to change?
I propose to change keybinding for NEW_TECHREPORT constant from ctrl+shift+R to ctrl+alt+R.

[m-mauersberger]

I would do it the other way because there are a lot of 'New' key bindings on ctrl+shift+... (e.g. New Book, New Proceedings,...).

[Gena928]

OK, the followed combinations are already assigned:
ctrl+shift+(A, C, D, E, I, K, L, M, N, O, P, R, S, T, U)

ctrl+shift+W?
ctrl+shift+J?

[tobiasdiez]

Personally, I would remove the default keybinding for "new techreport". I don't think that many people use that regularly to justify having a keybinding for it (but keep it as an option for people to set it later).

It may be a good idea to revise the keybindings in general, and come up with a consistent layout. Most of the current bindings are a result of step-by-step additions, instead of having a general idea. Some pointers for best practices: https://docs.microsoft.com/en-us/previous-versions/windows/desktop/dnacc/guidelines-for-keyboard-user-interface-design#assigning-shortcut-keys

[Gena928]

OK, I'll look into Microsoft guidelines.
Meanwhile, @m-mauersberger what do you think about removing hotkey for "Pull changes from shared database" ?

[Siedlerchr]

I think the hotkey for pulling changes is important for Databases that do not support pushing

[m-mauersberger]

For me the same, I would keep it. Mh, what about strg+alt+R or alt+shift+R for pull changes?

[Gena928]

Looks like alt+shift+R can be used.
I'll test it tomorrow on Mac & Windows.

[Gena928]

Seems like alt+shift+R is OK.
In case if no more comments, I'll create a pull request.

[Gena928]

Ouch ))
I've created a pull request and it shows 56 commits and 2 files change. Looks like this is because I created the branch from my Master, but it should be created from JabRef/Master.

Is that a problem? If yes, I will create a new commit.