Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exception when filling new group dialog wrongly #6624

Closed
1 task done
ilippert opened this issue Jun 20, 2020 · 1 comment · Fixed by #6642
Closed
1 task done

exception when filling new group dialog wrongly #6624

ilippert opened this issue Jun 20, 2020 · 1 comment · Fixed by #6642

Comments

@ilippert
Copy link
Contributor

JabRef 5.1--2020-06-17--ef0a6bb
Linux 5.6.18-300.fc32.x86_64 amd64
Java 14.0.1

Steps to reproduce the behavior:

  1. add subgroup
  2. collect by keywords
  3. generate groups by ... enter "field=specifier"

I recognise this may not be the content expected.

Solution: An error message that tells the user what input would be ideal.

Screenshot-20200620135115-620x495

Log File 
java.lang.StringIndexOutOfBoundsException: String index out of range: 0
  at java.base/java.lang.StringLatin1.charAt(Unknown Source)
  at java.base/java.lang.String.charAt(Unknown Source)
  at org.jabref/org.jabref.gui.groups.GroupDialogViewModel.resultConverter(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.scene.control.Dialog.setResultAndClose(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.scene.control.DialogPane.lambda$createButton$3(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventUtil.fireEventImpl(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventUtil.fireEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.event.Event.fireEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.scene.Node.fireEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.scene.control.Button.fire(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.scene.control.behavior.ButtonBehavior.mouseReleased(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.scene.control.inputmap.InputMap.handle(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventUtil.fireEventImpl(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventUtil.fireEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.event.Event.fireEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.scene.Scene$MouseHandler.process(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.scene.Scene.processMouseEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.scene.Scene$ScenePeerListener.mouseEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(Unknown Source)
  at java.base/java.security.AccessController.doPrivileged(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleMouseEvent$2(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.tk.quantum.GlassViewEventHandler.handleMouseEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.glass.ui.View.handleMouseEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.glass.ui.View.notifyMouse(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.glass.ui.gtk.GtkApplication.enterNestedEventLoopImpl(Native Method)
  at org.jabref.merged.module@5.1.628/com.sun.glass.ui.gtk.GtkApplication._enterNestedEventLoop(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.glass.ui.Application.enterNestedEventLoop(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.glass.ui.EventLoop.enter(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.tk.quantum.QuantumToolkit.enterNestedEventLoop(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.stage.Stage.showAndWait(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.scene.control.HeavyweightDialog.showAndWait(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.scene.control.Dialog.showAndWait(Unknown Source)
  at org.jabref/org.jabref.gui.JabRefDialogService.showCustomDialogAndWait(Unknown Source)
  at org.jabref/org.jabref.gui.groups.GroupTreeViewModel.lambda$addNewSubgroup$7(Unknown Source)
  at java.base/java.util.Optional.ifPresent(Unknown Source)
  at org.jabref/org.jabref.gui.groups.GroupTreeViewModel.addNewSubgroup(Unknown Source)
  at org.jabref/org.jabref.gui.groups.GroupTreeView.lambda$createContextMenuForGroup$20(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventUtil.fireEventImpl(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventUtil.fireEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.event.Event.fireEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.scene.control.MenuItem.fire(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.scene.control.ContextMenuContent$MenuItemContainer.doSelect(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.scene.control.ContextMenuContent$MenuItemContainer.lambda$createChildren$12(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventUtil.fireEventImpl(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.event.EventUtil.fireEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.event.Event.fireEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.scene.Scene$MouseHandler.process(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.scene.Scene.processMouseEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/javafx.scene.Scene$ScenePeerListener.mouseEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(Unknown Source)
  at java.base/java.security.AccessController.doPrivileged(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleMouseEvent$2(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.javafx.tk.quantum.GlassViewEventHandler.handleMouseEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.glass.ui.View.handleMouseEvent(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.glass.ui.View.notifyMouse(Unknown Source)
  at org.jabref.merged.module@5.1.628/com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
  at org.jabref.merged.module@5.1.628/com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$11(Unknown Source)
  at java.base/java.lang.Thread.run(Unknown Source)
@alex-petrov-vt
Copy link
Contributor

alex-petrov-vt commented Jun 24, 2020 •
edited
Loading

Hi, in this case, would it be a good idea to set delimiter and hierarchical delimiter to some default value (for example ',' and '>'), if none were specified by user? If so, I could probably fix this one.
I am new to open source and I'm just starting to explore JabRef codebase, so I wanted to double check if that adjustment would make sense overall. Thanks

@alex-petrov-vt alex-petrov-vt mentioned this issue Jun 27, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for exception thrown if no delimiters were specified
2 participants
@ilippert @alex-petrov-vt