Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues depending on external libraries #5226

Open
22 of 33 tasks
stefan-kolb opened this issue Aug 25, 2019 · 4 comments
Open
22 of 33 tasks

Issues depending on external libraries #5226

stefan-kolb opened this issue Aug 25, 2019 · 4 comments
Labels
build-system status: depends-on-external A bug or issue that depends on an update of an external library type: code-quality Issues related to code or architecture decisions

Comments

@stefan-kolb
Copy link
Member

stefan-kolb commented Aug 25, 2019

From #3421

  • Reimplement stuff concerning TextAreaSkin and TextFieldSkin
  • Fix and reenable CitationStyleTests

Morerover, the following needs to be fixed at some point but we cannot do much at the moment:

@JabRef JabRef deleted a comment from koppor Sep 8, 2019
@Siedlerchr Siedlerchr added build-system type: code-quality Issues related to code or architecture decisions labels Sep 12, 2019
@JabRef JabRef deleted a comment from Siedlerchr Oct 11, 2019
@tobiasdiez tobiasdiez changed the title Follow up issues Java 11 Issues depending on external libraries Oct 17, 2019
@tobiasdiez tobiasdiez added the status: depends-on-external A bug or issue that depends on an update of an external library label Dec 1, 2019
@Siedlerchr Siedlerchr pinned this issue Oct 14, 2020
@koppor koppor unpinned this issue Nov 10, 2020
@tobiasdiez tobiasdiez mentioned this issue Mar 10, 2021
5 tasks
@koppor koppor pinned this issue Jun 7, 2021
@koppor koppor unpinned this issue Jun 7, 2021
@Siedlerchr
Copy link
Member

Method too large error:
if I understand this correct from the badass jlink docs, all non modular jars are merged together in a single module and thus require no entry in the java list of modules that is this method, that is throwing the method too large error.

The badass-jlink plugin takes a more pragmatic approach by combining all non-modular dependencies into a single jar. This way, only the resulting merged module needs a module descriptor.

https://badass-jlink-plugin.beryx.org/releases/latest/

@koppor
Copy link
Member

koppor commented Jul 6, 2022

Method too large error:

I was in the jlink code - I think, we need to work on that method. I think, we want to learn how to generate bytecode, don't we?

grafik

@Siedlerchr
Copy link
Member

Handbook:
https://asm.ow2.io/asm4-guide.pdf

We would need to generate smaller methods and add references to these smaller methods then to the main module descriptor method

@Siedlerchr
Copy link
Member

Method too large was fixed by us and is now integrated in JDK 21.0.1 as well
https://www.oracle.com/java/technologies/javase/21-0-1-relnotes.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-system status: depends-on-external A bug or issue that depends on an update of an external library type: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

No branches or pull requests

4 participants