Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exporter tests #4272

Closed
tobiasdiez opened this issue Aug 16, 2018 · 12 comments
Closed

Fix exporter tests #4272

tobiasdiez opened this issue Aug 16, 2018 · 12 comments
Labels
export / save good first issue An issue intended for project-newcomers. Varies in difficulty. hacktoberfest Hacktoberfest tag. See https://hacktoberfest.digitalocean.com/faq/ for details. type: code-quality Issues related to code or architecture decisions

Comments

@tobiasdiez
Copy link
Member

As was recognized in #3959, some of the exporter tests are not working correctly.

@tobiasdiez tobiasdiez added the type: code-quality Issues related to code or architecture decisions label Aug 16, 2018
@Siedlerchr
Copy link
Member

MsOffice is resolved.
ModsExporter needs to be checked again

@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. hacktoberfest Hacktoberfest tag. See https://hacktoberfest.digitalocean.com/faq/ for details. labels Oct 2, 2018
@tobiasdiez
Copy link
Member Author

The tests are now fixed thanks to @NivedhaSunderraj.

@NivedhaSunderraj
Copy link
Contributor

@tobiasdiez I have fixed only testExportAsModsAndThenImportAsMods.... I couldn't fix the other two tests :(

@Siedlerchr
Copy link
Member

@NivedhaSunderraj Which ones are still failing?

@NivedhaSunderraj
Copy link
Contributor

@tobiasdiez testPerformExport and testImportAsModsAndExportAsMods are still not fixed and they both have same issue I think

@Siedlerchr
Copy link
Member

@NivedhaSunderraj Could you investigate what exactly is failing? Maybe the format of the xml files has changed? That was the case for the MsOffice stuff

@NivedhaSunderraj
Copy link
Contributor

@tobiasdiez Sure I'll look into it 👍

@tobiasdiez tobiasdiez reopened this Oct 15, 2018
@NivedhaSunderraj
Copy link
Contributor

@tobiasdiez Looks like the temp file created has an attribute 'xsi:type="mods:stringPlusLanguagePlusSupplied"' , but this is not in the xml files. And this caused the error... Do I add the attribute to xml file? Or modify export ?

@tobiasdiez
Copy link
Member Author

I'm not too familiar with the Office export, but this attribute does not seem to be utterly important and I'd hence say remove it from the reference files.

@NivedhaSunderraj
Copy link
Contributor

NivedhaSunderraj commented Oct 21, 2018

@tobiasdiez the xml reference files don't have the attribute ... It is being added when exporting it using modExport. So should I add the attribute in the reference xml file?

@tobiasdiez
Copy link
Member Author

Ah ok, I misunderstood you there. Yes, then please add it!

@NivedhaSunderraj
Copy link
Contributor

@tobiasdiez Sure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
export / save good first issue An issue intended for project-newcomers. Varies in difficulty. hacktoberfest Hacktoberfest tag. See https://hacktoberfest.digitalocean.com/faq/ for details. type: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

No branches or pull requests

3 participants