-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exporter tests #4272
Comments
MsOffice is resolved. |
The tests are now fixed thanks to @NivedhaSunderraj. |
@tobiasdiez I have fixed only testExportAsModsAndThenImportAsMods.... I couldn't fix the other two tests :( |
@NivedhaSunderraj Which ones are still failing? |
@tobiasdiez testPerformExport and testImportAsModsAndExportAsMods are still not fixed and they both have same issue I think |
@NivedhaSunderraj Could you investigate what exactly is failing? Maybe the format of the xml files has changed? That was the case for the MsOffice stuff |
@tobiasdiez Sure I'll look into it 👍 |
@tobiasdiez Looks like the temp file created has an attribute 'xsi:type="mods:stringPlusLanguagePlusSupplied"' , but this is not in the xml files. And this caused the error... Do I add the attribute to xml file? Or modify export ? |
I'm not too familiar with the Office export, but this attribute does not seem to be utterly important and I'd hence say remove it from the reference files. |
@tobiasdiez the xml reference files don't have the attribute ... It is being added when exporting it using modExport. So should I add the attribute in the reference xml file? |
Ah ok, I misunderstood you there. Yes, then please add it! |
@tobiasdiez Sure 👍 |
As was recognized in #3959, some of the exporter tests are not working correctly.
The text was updated successfully, but these errors were encountered: