Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace default group icon by small circle #4129

Closed
tobiasdiez opened this issue Jun 14, 2018 · 7 comments · Fixed by #7552
Closed

Replace default group icon by small circle #4129

tobiasdiez opened this issue Jun 14, 2018 · 7 comments · Fixed by #7552
Assignees
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. groups type: enhancement ui

Comments

@tobiasdiez
Copy link
Member

The current triangle has the disadvantage of being to small to show color and, moreover, can easily be mistaken for the arrow symbol that expands/collapses a group hierarchy.

Material design icons provide a full circle but this one is slightly to large.

@halirutan may I assign you this issue since you are our expert in creating custom font-based icons (e.g. a smaller circle or whatever you think is suitable)?

@halirutan
Copy link
Collaborator

halirutan commented Jun 14, 2018

I might be mistaken, but I believe this is not possible. When I encode the SVG's into a TTF, only their shapes, but not their absolute size is taken into account. They are all resized according to the font settings. To give an example, the VSCode icon I added recently has itself a size of 260pt x 260pt.

screen shot 2018-06-14 at 15 56 20

I did not change anything in this icon and directly imported it into the TTF where it was rescaled to match the size of the other glyphs. As you can imagine, creating a smaller circle would be useless, as it would be resized to the original glyph-size.

What you can try is to use a font-size that is larger for the group-icons.

@tobiasdiez
Copy link
Member Author

Just a guess, but what happens if you add transparent space around the icon?

@matthiasgeiger
Copy link
Member

Just another Idea: Styling the standard "middle dot' (\u00B7 or ·) is not doing the Trick? I think it should be part of most standard fonts, but have not checked it...

@halirutan
Copy link
Collaborator

@tobiasdiez That might work but it depends on the tool that builds the font from the SVG. Some tools simply grab all paths and put them into the icon. Currently, I don't have that much time at hand as building and updating the TTF is not an automatic process at the moment. Maybe someone can check if using the normal circle we already have in a different size works too.

@tobiasdiez tobiasdiez added this to the v5.0 milestone Sep 27, 2019
@tobiasdiez tobiasdiez removed this from the v5.0 milestone Feb 23, 2020
@github-actions
Copy link
Contributor

This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs.

As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:

  • If there has been a longer discussion, add a short summary of the most important points as a new comment (if not yet existing).
  • Provide further steps or information on how to reproduce this issue.
  • Upvote the initial post if you like to see it implemented soon. Votes are not the only metric that we use to determine the requests that are implemented, however, they do factor into our decision-making process.
  • If all information is provided and still up-to-date, then just add a short comment that the issue is still relevant.

Thank you for your contribution!

@tobiasdiez tobiasdiez added good first issue An issue intended for project-newcomers. Varies in difficulty. and removed status: stale labels Jan 1, 2021
@tobiasdiez
Copy link
Member Author

Maybe one can also use a scaling of the materialdesign dot (or maybe they provide in the meantime a different dot).

@tobiasdiez
Copy link
Member Author

Thanks to @mohit038 this should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. groups type: enhancement ui
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants