Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom base ui theme #12352

Open
tobiasdiez opened this issue Feb 20, 2018 · 3 comments
Open

Create custom base ui theme #12352

tobiasdiez opened this issue Feb 20, 2018 · 3 comments

Comments

@tobiasdiez
Copy link
Member

Currently, we use the built-in JavaFX theme "Modena" as the base and overwrite certain styles. In some cases this is a bit problematic and it would be better to copy modena.css and make our changes directly to this file.
The new base UI css file can be registered using https://docs.oracle.com/javase/8/javafx/api/javafx/application/Application.html#setUserAgentStylesheet-java.lang.String-

@Siedlerchr
Copy link
Member

I guess with our DarkTheme and the LightTheme this issue is now obsolete.

@tobiasdiez
Copy link
Member Author

Nope, the Base.css is applied on top of Modena. Since we have many changes, it would be worthwhile to completely replace Modena by our base css.

@tobiasdiez tobiasdiez reopened this Oct 25, 2019
@koppor koppor transferred this issue from JabRef/jabref-koppor Jan 4, 2025
@Siedlerchr
Copy link
Member

I'm against copying modena. If there are updates to Javafx we would always need to re copy the whole stuff.
it might be better using https://github.com/mkpaz/atlantafx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants