Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate error with custom emissions #69

Closed
5 tasks done
stephpenn1 opened this issue May 3, 2024 · 4 comments
Closed
5 tasks done

Investigate error with custom emissions #69

stephpenn1 opened this issue May 3, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@stephpenn1
Copy link
Collaborator

stephpenn1 commented May 3, 2024

  • Run the current version in the redesign tab and reproduce the error
  • Investigate where the error is coming from
  • If the error is easy to fix, fix in here and then copy over code into h2
  • If error is not easy to fix, can we pull the structure into h2 and adapt it for the new files?
  • Update to new hector v3 emissions files for SSPs, located here
@stephpenn1 stephpenn1 added the bug Something isn't working label May 3, 2024
@ciara-donegan
Copy link
Collaborator

ciara-donegan commented May 8, 2024

The issue in the current version is with the three HCFC variables (HCFC22, HCFC141b, and HCFC142b) being read in. Unsure yet exactly why they aren't working, but custom emissions can be run by just removing them from the emissions file. The attached RCP 4.5 template works in the current version of HectorUI.

RCP45_custom_template_fixed.csv

Setting custom emissions with Hector v3 actually has different issues -- the units in the emissions template files are incorrect, and three variables don't work properly: HFC245fa_constrain (the "fa" is missing in the header name in the template), HFC365_constrain, and HFC365_emissions (not actually used in Hector). The attached SSP 1-1.9 csv file works with Hector v3 (units and HFC245fa fixed, HFC365 vars removed).

ssp119_emiss-constraints_rf_fixed.csv

@stephpenn1
Copy link
Collaborator Author

Great, let's create patch templates for all RCPs

@stephpenn1
Copy link
Collaborator Author

For new version of HectorUI, use r6 class for running custom emissions

@ciara-donegan
Copy link
Collaborator

All RCP templates working with the current version of HectorUI (HCFC variables removed):
RCP26_custom_template_fixed.csv
RCP45_custom_template_fixed.csv
RCP6_custom_template_fixed.csv
RCP85_custom_template_fixed.csv

This was referenced Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants