Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NBP constraint crashes model in some circumstances #737

Open
bpbond opened this issue Mar 20, 2024 · 2 comments
Open

NBP constraint crashes model in some circumstances #737

bpbond opened this issue Mar 20, 2024 · 2 comments
Assignees

Comments

@bpbond
Copy link
Member

bpbond commented Mar 20, 2024

@jk-brown and @kendalynnm have found a case where supplying the model with an NBP constraint crashes it. 💥

Our automated tests currently check that things are OK with a 21st-century constraint...but giving a 100-year 20th century constraint causes a crash.

@bpbond bpbond self-assigned this Mar 20, 2024
@bpbond
Copy link
Member Author

bpbond commented Apr 25, 2024

The proximal cause of the crash was a fluxpool negative-value error. This is easy to fix/work around...

But the deeper issue is that there's some issue with the NBP constraint logic, and the model is having to work increasingly hard to meet it the constraint (eventually transferring tens of Pg C to the deep ocean before crashing with a mass balance error in the middle of the 21st century). 😕

@bpbond
Copy link
Member Author

bpbond commented Apr 25, 2024

Stopping point for now

  • Comparing constrained and free runs, atmosphere pool visibly diverging by 1763
  • Do we want to remove NBP constraint consideration from calc_derivs? Think about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant