Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing logic in find_all_file_versions() with multi-line regex #36

Open
JElchison opened this issue Oct 17, 2014 · 0 comments

Comments

@JElchison
Copy link
Owner

It may be possible to replace the complicated logic in find_all_file_versions() with an expanded histRegex.

Consider:

  • re.MULTILINE(specifically, $ and ^ will match beginnings/ends of lines)
    • ^ will also match end of entire buffer (useful for grabbing last comment, if present)
  • re.findall() (specifically, its non-overlapping quality)
  • capitalizing on Comments - text, which isn't currently in histRegex
  • may need to find some way to lump end of comment into previous match
    • possibly split buffer into pieces, using MatchObject.start() as separation point
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant