Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Broken in Ember 1.13 #2

Closed
omghax opened this issue May 14, 2015 · 2 comments
Closed

Broken in Ember 1.13 #2

omghax opened this issue May 14, 2015 · 2 comments

Comments

@omghax
Copy link
Contributor

omghax commented May 14, 2015

See emberjs/ember.js#11170.

@jherdman
Copy link

Was this resolved?

@omghax
Copy link
Contributor Author

omghax commented Mar 24, 2016

This has been resolved with the 1.2.0 release, though it requires some changes to the way the components are used in the templates:

{{#ivy-tabs}}
  {{#ivy-tab-list}}
    {{#ivy-tab}}tab 1{{/ivy-tab}}
    {{#ivy-tab}}tab 2{{/ivy-tab}}
  {{/ivy-tab-list}}
  {{ivy-tab-panel}}panel 1{{/ivy-tab-panel}}
  {{ivy-tab-panel}}panel 2{{/ivy-tab-panel}}
{{/ivy-tabs}}

would become:

{{#ivy-tabs as |tabsContainer|}}
  {{#ivy-tab-list tabsContainer=tabsContainer as |tabList|}}
    {{#ivy-tab tabList=tabList}}tab 1{{/ivy-tab}}
    {{#ivy-tab tabList=tabList}}tab 2{{/ivy-tab}}
  {{/ivy-tab-list}}
  {{ivy-tab-panel tabsContainer=tabsContainer}}panel 1{{/ivy-tab-panel}}
  {{ivy-tab-panel tabsContainer=tabsContainer}}panel 2{{/ivy-tab-panel}}
{{/ivy-tabs}}

The old parentView-based way should still work, but I noticed some of the tests were failing in 1.13, so it seemed like passing block arguments around was the better solution long-term. Eventually once I'm able to drop support for Ember versions < 2.3, I plan to make this use contextual components instead.

@omghax omghax closed this as completed Mar 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants