Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facets module installed by playbook (^1.6) is out of date (2.0.2 available) #2121

Closed
rosiel opened this issue Jun 7, 2022 · 3 comments
Closed
Assignees
Labels
Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’)

Comments

@rosiel
Copy link
Member

rosiel commented Jun 7, 2022

Overview of feature request

We should update facets and ensure that our out of the box config works for the new 2.x version.

What kind of user is the feature intended for?

Sys admin and user

What inspired the request?
Going through seeing what old versions we're installing

What existing behavior do you want changed?
not really sure if it'll change behaviour.

Any brand new behavior do you want to add to Islandora?
But apparently we could set up something called a hierarchical date granularity facet. https://www.drupal.org/docs/contributed-modules/facets

Any related open or closed issues to this feature request?
no

@rosiel rosiel added the Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’) label Jun 7, 2022
@alxp
Copy link
Contributor

alxp commented Jun 8, 2022

This should be a dependency in islandora_defaults, which has some facet configs in its 'optional' folder.

@rosiel
Copy link
Member Author

rosiel commented Jul 13, 2022

Due to the config being "optional", it is designed to load those configs if facets is already present. It would break the model that is currently in place to make it a dependency of defaults - that would require us to move those configs to 'install' instead of 'optional'. It makes sense given the way that defaults is set up that we have facets in the playbook.

But there are a number of other modules that are required by the playbook despite being required by islandora or islandora default - I've made a PR to remove them (as well as update some versions).

@alxp
Copy link
Contributor

alxp commented Jul 14, 2022

Resolved by Islandora-Devops/islandora-playbook#222

@alxp alxp closed this as completed Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’)
Projects
None yet
Development

No branches or pull requests

2 participants