Comment module is a dependency of a bunch of Islandora modules

[mjordan]

Looks like the core Comment module is a dependency for the following modules:

Which makes it difficult to uninstall it. Looking at the .info.yml files for the modules listed above, it's there for Islandora Defaults and ... Solr Search Defaults (not one of ours).

So I guess the only way to not have comments on a site is to not configure any permissions for it? Here's the policy of the Solr Search Defaults maintainers: https://www.drupal.org/project/search_api_solr/issues/2938102.

[dannylamb]

I think if we want to avoid that then we're saddled with maintaining our own solr config and not using anything from search_api_solr_default (which may not be a bad thing?).

[mjordan]

Since defaults provides standard fields on repository objects, it might be nice to provide a corresponding set of search configs. As it is, admins still need to configure all the "islandora" fields at admin/config/search/search-api/index/default_solr_index/fields.

[dannylamb]

Totally. And facets. We should provide reasonable defaults for those, too.

[mjordan]

Now that we're not relying on search_api_solr_default can we remove the dependency on the comment module?

[mjordan]

Bumping this... now that we have islandora_search, does the comment module still need to be a dependency of islandora_defaults, islandora_oaipmh, and islandora_search? comment is a dependency of search_api_solr_defaults, which in turn is a dependency of islandora_search. If we can get rid of that last dependency, we can get rid of the comment module (I think).

[seth-shaw-unlv]

So, a quick grep shows that the only reference to search_api_solr_defaults is in the islandora_search info file. Removing that reference should allow us to remove comment from the islandora_defaults info file.

[seth-shaw-unlv]

I have a branch for this, but I need to build a fresh box from scratch to test it before I issue the PR.

[seth-shaw-unlv]

Actually, it will be a lot easier to test this as a branch on islandora_defaults itself...

[seth-shaw-unlv]

Okay, I've tested my branch and it does remove the dependency on Comment. HOWEVER, it will still appear on a standard Drupal install because it is used by the Article content type. To truly remove Comment you have to delete the comment field from the Article content type and then uninstall the module.

PR incoming.

[mjordan]

All resolved, thanks very much @seth-shaw-unlv!