-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What the heck does "Map URI to Predicate" mean? #1303
Comments
Oh... Here's a further complication. This reaction, when executed, will also:
This is why the default "self-reference" for media objects (i.e. configured in islandora defaults) uses Mind blown. This class kind of does two different things, but they're kind of the same thing, and it's confusing to think about and document. I get it. |
@rosiel it does that weird behaviour for media so that we properly store the subject of the RDF for a binary as the binary. Instead of the media. This is a weirdness of Fedora too. If you goto a file in Fedora and look at the RDF (easier using curl) though the URL is |
@rosiel++ I totally forgot about that little twist. |
My .02 (which is somewhat of an aside, as it sounds like this is complicated to change given the above) -- JSON-LD is just a serialization, but the predicate is part of RDF. So naming it JSON-LD is misleading, as it's not JSON-LD, it's an RDF predicate that I8 serializes as JSON-LD (versus, say, turtle, or rdfxml) |
@bseeger, that is true, but (currently) the RDF module doesn't support any of these alters, so we rely on the JSON-LD module for these tasks. So, while the concept is RDF centric, the implementation is JSON-LD centric. I think using JSON-LD in the name is necessary because it emphasizes where this magic happens. |
Hmm, there's a good point here. I'm not sure if this alter happens before or after "turning the rdf into jsonld" (if such a thing occurs). But I think that distinction is important, if we've designed this to be flexible, the name should say what it actually does. Thanks @bseeger . |
First, the JSON-LD module serializes the entity based on the RDF mapping; i.e. 'turning the rdf into jsonld'. Afterwards the JSON-LD module executes any implementations of |
Resolved via Islandora/islandora@1e0b98e |
The interface contains a context reaction with:
What it does, which is not clear from the wording, is allow you to configure the Fedora URI to contain a "schema:sameAs" (or some other predicate) pointing to its Drupal URI counterpart.
I propose to change this to:
Wording changes welcome!
I have a pull request ready to open if there's agreement on the wording.
The text was updated successfully, but these errors were encountered: