Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

claw-playbook should use PHP 7.1+ #1007

Closed
whikloj opened this issue Jan 18, 2019 · 2 comments
Closed

claw-playbook should use PHP 7.1+ #1007

whikloj opened this issue Jan 18, 2019 · 2 comments

Comments

@whikloj
Copy link
Member

whikloj commented Jan 18, 2019

Currently the claw-playbook ansible scripts load PHP 7.0. As we require PHP 7.1 or greater we should actually install PHP 7.1 or greater.

@kayakr
Copy link
Contributor

kayakr commented Feb 5, 2019

@whikloj This is working for me:

diff --git a/crayfish.yml b/crayfish.yml
index a6ce61a..fffc2f4 100644
--- a/crayfish.yml
+++ b/crayfish.yml
@@ -3,10 +3,17 @@
 - hosts: crayfish
   become: yes
 
+  vars:
+    php_version: '7.1'
+    php_packages_extra:
+      - php7.1-mysql
+      - php7.1-pgsql
+
   roles:
     - name: geerlingguy.repo-remi
       when: ansible_os_family == "RedHat"
     - geerlingguy.apache
+    - geerlingguy.php-versions
     - geerlingguy.php
     - geerlingguy.git
     - geerlingguy.composer
diff --git a/requirements.yml b/requirements.yml
index a2641f4..1471c16 100644
--- a/requirements.yml
+++ b/requirements.yml
@@ -10,6 +10,9 @@
 - src: geerlingguy.php
   version: 3.6.0
 
+- src: geerlingguy.php-versions
+  version: 2.1.3
+
 - src: geerlingguy.composer
   version: 1.7.0
 
diff --git a/vars/Debian.yml b/vars/Debian.yml
index bfccdb3..10dc2cd 100644
--- a/vars/Debian.yml
+++ b/vars/Debian.yml
@@ -1,6 +1,6 @@
 ---
 
 php_packages_extra:
-  - libapache2-mod-php7.0
-  - php7.0-mysql
-  - php7.0-pgsql
+  - libapache2-mod-php7.1
+  - php7.1-mysql
+  - php7.1-pgsql
diff --git a/webserver.yml b/webserver.yml
index 7fff33e..0c3fe77 100644
--- a/webserver.yml
+++ b/webserver.yml
@@ -3,10 +3,16 @@
 - hosts: webserver
   become: yes
 
+  vars:
+    php_version: "7.1"
+
   roles:
     - name: geerlingguy.repo-remi
       when: ansible_os_family == "RedHat"
     - geerlingguy.apache
+    - geerlingguy.php-versions
     - geerlingguy.php
     - geerlingguy.php-mysql
     - geerlingguy.git

FYI, when I first attempted this I accidentally updated to PHP 7.2 and that broke due to https://www.drupal.org/project/drupal/issues/2959333

@whikloj
Copy link
Member Author

whikloj commented Feb 5, 2019

@kayakr nice, do you have any suggestions for the Centos side and do you feel like opening a PR with these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants