-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate thumbnails for videos #1005
Generate thumbnails for videos #1005
Comments
linking to #929 |
@dannylamb We discussed having a common approach to derivative creation. Is that to be explored? Or since we can customize the input parameters with actions, we should be good to with the approach stated here. Please confirm. |
The common approach we have now is re-using the camel routes to connect the derivative microservices back into the repository. We've got that, but that's really only for adding new microservices. For this we'll either have to adapt homarus or make a new action that has different Islandora Args. It all comes down to the ffmpeg command you have to run to extract a thumbnail. |
Adding the ffmpeg format image2pipe to the config, then passing appropriate params will create thumbnail image. Example:
We can start with the above and then refine the logic to set more appropriate time frame later as in the 7.x stack. I set up the context and action, it did not create it. Need to troubleshoot that further. But I do note that context that is setup to fire on any Service file can be problamatic. Also, I am not sure if Alpaca is setup to handle creation of multiple file types for video!
|
I just modified the validator in the form for Needs some image styles, but hey 🎉 |
@Natkeeran^^ PRs are up. Testing instructions in https://github.com/Islandora-CLAW/islandora_demo/pull/26 |
When ingested, video derivatives are made, but it would be nice if we could extract a thumbnail from the video. We should be able to adapt Homarus to read Accept headers to know if it should make images or videos. The ffmpeg command should be altered accordingly. The logic would go roughly here: https://github.com/Islandora-CLAW/Crayfish/blob/master/Homarus/src/Controller/HomarusController.php#L113 I imagine in the long run we'll want to do audio derivatives this way too, so keep that in mind, even though it's certainly out of scope for this issue.
The text was updated successfully, but these errors were encountered: